7448f02b7c
Initial proof of concept of giving splitting cond sampling between multiple GPUs
2025-01-08 03:33:05 -06:00
871258aa72
Add get_all_torch_devices to get detected devices intended for current torch hardware device
2025-01-07 21:06:03 -06:00
66838ebd39
Merge branch 'comfyanonymous:master' into multigpu_support
2025-01-07 20:11:27 -06:00
d0f3752e33
Properly calculate inner dim for t5 model.
...
This is required to support some different types of t5 models.
2025-01-07 17:33:03 -05:00
3cd4c5cb0a
Rename AddModelsHooks to AdditionalModelsHook, rename SetInjectionsHook to InjectionsHook (not yet implemented, but at least getting the naming figured out)
2025-01-07 02:22:49 -06:00
4209edf48d
Make a few more samplers deterministic.
2025-01-07 02:12:32 -05:00
11c6d56037
Merge branch 'master' into hooks_part2
2025-01-07 01:01:53 -06:00
216fea15ee
Made TransformerOptionsHook contribute to registered hooks properly, added some doc strings and removed a so-far unused variable
2025-01-07 00:59:18 -06:00
58bf8815c8
Add a get_injections function to ModelPatcher
2025-01-06 20:34:30 -06:00
d055325783
Document get_attr and get_model_object ( #6357 )
...
* Document get_attr and get_model_object
* Update model_patcher.py
* Update model_patcher.py
* Update model_patcher.py
2025-01-06 20:12:22 -05:00
1b38f5bf57
removed 4 whitespace lines to satisfy Ruff,
2025-01-06 17:11:12 -06:00
2724ac4a60
Merge branch 'master' into hooks_part2
2025-01-06 17:04:24 -06:00
f48f90e471
Make hook_scope functional for TransformerOptionsHook
2025-01-06 02:23:04 -06:00
916d1e14a9
Make ancestral samplers more deterministic.
2025-01-06 03:04:32 -05:00
0a7e2ae787
Filter only registered hooks on self.conds in CFGGuider.sample
2025-01-06 01:04:29 -06:00
03a97b604a
Fix performance of hooks when hooks are appended via Cond Pair Set Props nodes by properly caching between positive and negative conds, make hook_patches_backup behave as intended (in the case that something pre-registers WeightHooks on the ModelPatcher instead of registering it at sample time)
2025-01-06 01:03:59 -06:00
c496e53519
In inner_sample, change "sigmas" to "sampler_sigmas" in transformer_options to not conflict with the "sigmas" that will overwrite "sigmas" in _calc_cond_batch ( #6360 )
2025-01-06 01:36:47 -05:00
4446c86052
Made hook clone code sane, made clear ObjectPatchHook and SetInjectionsHook are not yet operational
2025-01-05 22:25:51 -06:00
8270ff312f
Refactored 'registered' to be HookGroup instead of a list of Hooks, made AddModelsHook operational and compliant with should_register result, moved TransformerOptionsHook handling out of ModelPatcher.register_all_hook_patches, support patches in TransformerOptionsHook properly by casting any patches/wrappers/hooks to proper device at sample time
2025-01-05 21:07:02 -06:00
db2d7ad9ba
Merge branch 'add_sample_sigmas' into hooks_part2
2025-01-05 15:45:13 -06:00
6620d86318
In inner_sample, change "sigmas" to "sampler_sigmas" in transformer_options to not conflict with the "sigmas" that will overwrite "sigmas" in _calc_cond_batch
2025-01-05 15:26:22 -06:00
d45ebb63f6
Remove old unused function.
2025-01-04 07:20:54 -05:00
111fd0cadf
Refactored HookGroup to also store a dictionary of hooks separated by hook_type, modified necessary code to no longer need to manually separate out hooks by hook_type
2025-01-04 02:04:07 -06:00
776aa734e1
Refactor WrapperHook into TransformerOptionsHook, as there is no need to separate out Wrappers/Callbacks/Patches into different hook types (all affect transformer_options)
2025-01-04 01:02:21 -06:00
5a2ad032cb
Cleaned up hooks.py, refactored Hook.should_register and add_hook_patches to use target_dict instead of target so that more information can be provided about the current execution environment if needed
2025-01-03 20:02:27 -06:00
9e9c8a1c64
Clear cache as often on AMD as Nvidia.
...
I think the issue this was working around has been solved.
If you notice that this change slows things down or causes stutters on
your AMD GPU with ROCm on Linux please report it.
2025-01-02 08:44:16 -05:00
0f11d60afb
Fix temporal tiling for decoder, remove redundant tiles. ( #6306 )
...
This commit fixes the temporal tile size calculation, and removes
a redundant tile at the end of the range when its elements are
completely covered by the previous tile.
Co-authored-by: Andrew Kvochko <a.kvochko@lightricks.com >
2025-01-01 16:29:01 -05:00
79eea51a1d
Fix and enforce all ruff W rules.
2025-01-01 03:08:33 -05:00
c0338a46a4
Fix unknown sampler error handling in calculate_sigmas function ( #6280 )
...
Modernize calculate_sigmas function
2024-12-31 17:33:50 -05:00
1c99734e5a
Add missing model_options param ( #6296 )
2024-12-31 14:46:55 -05:00
67758f50f3
Fix custom node type-hinting examples ( #6281 )
...
* Fix import in comfy_types doc / sample
* Clarify docstring
2024-12-31 03:41:09 -05:00
b7572b2f87
Fix and enforce no trailing whitespace.
2024-12-31 03:16:37 -05:00
a90aafafc1
Add kl_optimal scheduler ( #6206 )
...
* Add kl_optimal scheduler
* Rename kl_optimal_schedule to kl_optimal_scheduler to be more consistent
2024-12-30 05:09:38 -05:00
d9b7cfac7e
Fix and enforce new lines at the end of files.
2024-12-30 04:14:59 -05:00
3507870535
Add 'sigmas' to transformer_options so that downstream code can know about the full scope of current sampling run, fix Hook Keyframes' guarantee_steps=1 inconsistent behavior with sampling split across different Sampling nodes/sampling runs by referencing 'sigmas' ( #6273 )
2024-12-30 03:42:49 -05:00
a618f768e0
Auto reshape 2d to 3d latent for single image generation on video model.
2024-12-29 02:26:49 -05:00
b504bd606d
Add ruff rule for empty line with trailing whitespace.
2024-12-28 05:23:08 -05:00
d170292594
Remove some trailing white space.
2024-12-27 18:02:30 -05:00
9cfd185676
Add option to log non-error output to stdout ( #6243 )
...
* nit
* Add option to log non-error output to stdout
- No change to default behaviour
- Adds CLI argument: --log-stdout
- With this arg present, any logging of a level below logging.ERROR will be sent to stdout instead of stderr
2024-12-27 14:40:05 -05:00
4b5bcd8ac4
Closer memory estimation for hunyuan dit model.
2024-12-27 07:37:00 -05:00
ceb50b2cbf
Closer memory estimation for pixart models.
2024-12-27 07:30:09 -05:00
160ca08138
Use python 3.9 in launch test instead of 3.8
...
Fix ruff check.
2024-12-26 20:05:54 -05:00
c4bfdba330
Support ascend npu ( #5436 )
...
* support ascend npu
Co-authored-by: YukMingLaw <lymmm2@163.com >
Co-authored-by: starmountain1997 <guozr1997@hotmail.com >
Co-authored-by: Ginray <ginray0215@gmail.com >
2024-12-26 19:36:50 -05:00
ee9547ba31
Improve temporal VAE Encode (Tiled) math.
2024-12-26 07:18:49 -05:00
19a64d6291
Cleanup some mac related code.
2024-12-25 05:32:51 -05:00
b486885e08
Disable bfloat16 on older mac.
2024-12-25 05:18:50 -05:00
0229228f3f
Clean up the VAE dtypes code.
2024-12-25 04:50:34 -05:00
99a1fb6027
Make fast fp8 take a bit less peak memory.
2024-12-24 18:05:19 -05:00
73e04987f7
Prevent black images in VAE Decode (Tiled) node.
...
Overlap should be minimum 1 with tiling 2 for tiled temporal VAE decoding.
2024-12-24 07:36:30 -05:00
5388df784a
Add temporal tiling to VAE Encode (Tiled) node.
2024-12-24 07:10:09 -05:00
