From 42147df459d0597db232a0664d1860c3db8d0eef Mon Sep 17 00:00:00 2001
From: Yang <3349368+m3ngyang@users.noreply.github.com>
Date: Fri, 10 Oct 2025 18:28:39 +0800
Subject: [PATCH] fix: document deletion bug (#2248)

---
 backend/domain/knowledge/service/knowledge.go | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/domain/knowledge/service/knowledge.go b/backend/domain/knowledge/service/knowledge.go
index 6bef912b9..c119119fb 100644
--- a/backend/domain/knowledge/service/knowledge.go
+++ b/backend/domain/knowledge/service/knowledge.go
@@ -433,17 +433,17 @@ func (k *knowledgeSVC) DeleteDocument(ctx context.Context, request *DeleteDocume
 		}
 	}
 
-	err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})
-	if err != nil {
-		return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))
-	}
-
 	sliceIDs, err := k.sliceRepo.GetDocumentSliceIDs(ctx, []int64{request.DocumentID})
 	if err != nil {
 		logs.CtxErrorf(ctx, "[DeleteDocument] get document slice ids failed, err: %v", err)
 		return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))
 	}
 
+	err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})
+	if err != nil {
+		return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))
+	}
+
 	if err = k.emitDeleteKnowledgeDataEvent(ctx, doc.KnowledgeID, sliceIDs, strconv.FormatInt(request.DocumentID, 10)); err != nil {
 		return err
 	}