diff --git a/web/app/components/base/float-right-container/__tests__/index.spec.tsx b/web/app/components/base/float-right-container/__tests__/index.spec.tsx
index 4466b2cadc..6f84e5afd8 100644
--- a/web/app/components/base/float-right-container/__tests__/index.spec.tsx
+++ b/web/app/components/base/float-right-container/__tests__/index.spec.tsx
@@ -90,7 +90,7 @@ describe('FloatRightContainer', () => {
)
await screen.findByRole('dialog')
- const closeIcon = screen.getByTestId('close-icon')
+ const closeIcon = screen.getByRole('button', { name: 'common.operation.close' })
expect(closeIcon).toBeInTheDocument()
await userEvent.click(closeIcon)
diff --git a/web/app/components/base/float-right-container/index.tsx b/web/app/components/base/float-right-container/index.tsx
index db3b73da95..ee79b22226 100644
--- a/web/app/components/base/float-right-container/index.tsx
+++ b/web/app/components/base/float-right-container/index.tsx
@@ -63,7 +63,6 @@ const FloatRightContainer = ({
)}
diff --git a/web/app/components/base/form/components/field/__tests__/checkbox.spec.tsx b/web/app/components/base/form/components/field/__tests__/checkbox.spec.tsx
index 6005d9261b..d5e5a6d25c 100644
--- a/web/app/components/base/form/components/field/__tests__/checkbox.spec.tsx
+++ b/web/app/components/base/form/components/field/__tests__/checkbox.spec.tsx
@@ -21,7 +21,7 @@ describe('CheckboxField', () => {
it('should toggle on when unchecked users click the checkbox', () => {
mockField.state.value = false
render()
- fireEvent.click(screen.getByTestId('checkbox-checkbox-field'))
+ fireEvent.click(screen.getByRole('checkbox', { name: 'Enable feature' }))
expect(mockField.handleChange).toHaveBeenCalledWith(true)
})
diff --git a/web/app/components/base/form/components/field/checkbox.tsx b/web/app/components/base/form/components/field/checkbox.tsx
index cd5b95f2fa..29ba50d56b 100644
--- a/web/app/components/base/form/components/field/checkbox.tsx
+++ b/web/app/components/base/form/components/field/checkbox.tsx
@@ -19,6 +19,7 @@ const CheckboxField = ({
{
field.handleChange(!field.state.value)
}}
diff --git a/web/app/components/base/input/__tests__/index.spec.tsx b/web/app/components/base/input/__tests__/index.spec.tsx
index 7dc5d22eab..90bac0095f 100644
--- a/web/app/components/base/input/__tests__/index.spec.tsx
+++ b/web/app/components/base/input/__tests__/index.spec.tsx
@@ -66,7 +66,7 @@ describe('Input component', () => {
it('calls onClear when clear icon is clicked', () => {
const onClear = vi.fn()
render()
- const clearIconContainer = screen.getByTestId('input-clear')
+ const clearIconContainer = screen.getByRole('button', { name: 'common.operation.clear' })
fireEvent.click(clearIconContainer!)
expect(onClear).toHaveBeenCalledTimes(1)
})
diff --git a/web/app/components/base/input/index.tsx b/web/app/components/base/input/index.tsx
index d41cd2c0cf..ba69670d2d 100644
--- a/web/app/components/base/input/index.tsx
+++ b/web/app/components/base/input/index.tsx
@@ -109,13 +109,14 @@ const Input = React.forwardRef(({
{...props}
/>
{!!(showClearIcon && value && !disabled && !destructive) && (
-
-
-
+
+
)}
{destructive && (