mirror of
https://github.com/langgenius/dify.git
synced 2026-05-04 17:38:04 +08:00
refactor(api): rename placeholder to default_value in various parts
Previously the fields / classes are named with `placeholder`. However, the actual purpose is to use as default values. This commit addresses this problem by correcting names for relevant fields / classes. - FormInputPlaceholder - FormInput.placeholder - HumanInputRequiredResponse.resolved_placeholder_values - HumanInputFormDefinition.resolved_placeholder_values - FormCreateParams.resolved_placeholder_values - HumanInputRequired.resolved_placeholder_values - The `resolved_placeholder_values` argument of _create_human_input_delivery_test_form - The `resolved_placeholder_values` inside _jsonify_form_definition
This commit is contained in:
@ -74,7 +74,7 @@ def _build_form_params(delivery_methods: list[EmailDeliveryMethod]) -> FormCreat
|
||||
rendered_content="<p>Approve?</p>",
|
||||
delivery_methods=delivery_methods,
|
||||
display_in_ui=False,
|
||||
resolved_placeholder_values={},
|
||||
resolved_default_values={},
|
||||
)
|
||||
|
||||
|
||||
@ -164,7 +164,7 @@ class TestHumanInputFormRepositoryImplWithContainers:
|
||||
assert len(external_payloads) == 1
|
||||
assert external_payloads[0].email == "external@example.com"
|
||||
|
||||
def test_create_form_persists_placeholder_values(self, db_session_with_containers: Session) -> None:
|
||||
def test_create_form_persists_default_values(self, db_session_with_containers: Session) -> None:
|
||||
engine = db_session_with_containers.get_bind()
|
||||
assert isinstance(engine, Engine)
|
||||
tenant, _ = _create_tenant_with_members(
|
||||
@ -187,7 +187,7 @@ class TestHumanInputFormRepositoryImplWithContainers:
|
||||
rendered_content="<p>Approve?</p>",
|
||||
delivery_methods=[],
|
||||
display_in_ui=False,
|
||||
resolved_placeholder_values=resolved_values,
|
||||
resolved_default_values=resolved_values,
|
||||
)
|
||||
|
||||
form_entity = repository.create_form(params)
|
||||
@ -199,7 +199,7 @@ class TestHumanInputFormRepositoryImplWithContainers:
|
||||
|
||||
assert form_model is not None
|
||||
definition = FormDefinition.model_validate_json(form_model.form_definition)
|
||||
assert definition.placeholder_values == resolved_values
|
||||
assert definition.default_values == resolved_values
|
||||
|
||||
def test_create_form_persists_display_in_ui(self, db_session_with_containers: Session) -> None:
|
||||
engine = db_session_with_containers.get_bind()
|
||||
@ -224,7 +224,7 @@ class TestHumanInputFormRepositoryImplWithContainers:
|
||||
rendered_content="<p>Approve?</p>",
|
||||
delivery_methods=[WebAppDeliveryMethod()],
|
||||
display_in_ui=True,
|
||||
resolved_placeholder_values={},
|
||||
resolved_default_values={},
|
||||
)
|
||||
|
||||
form_entity = repository.create_form(params)
|
||||
|
||||
@ -95,7 +95,7 @@ def _build_form(db_session_with_containers, tenant, account):
|
||||
rendered_content="Rendered",
|
||||
delivery_methods=node_data.delivery_methods,
|
||||
display_in_ui=False,
|
||||
resolved_placeholder_values={},
|
||||
resolved_default_values={},
|
||||
)
|
||||
return repo.create_form(params)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user