youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-25 03:17:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove shortcut

Browse Source
This commit is contained in:
Joel
2026-05-13 16:41:40 +08:00
committed by Jingyi-Dify
parent 0ca25fa371
commit 4aa7410f69
2 changed files with 1 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
web/app/components/apps/__tests__/list.spec.tsx
View File

@ -494,30 +494,6 @@ describe('List', () => {
expect(screen.getByTestId('create-dsl-modal'))!.toBeInTheDocument()
})
it('should open blank app modal with create shortcut', () => {
renderList()
fireEvent.keyDown(window, { key: 'n', metaKey: true })
expect(screen.getByTestId('create-app-modal'))!.toBeInTheDocument()
})
it('should open template dialog with create template shortcut', () => {
renderList()
fireEvent.keyDown(window, { key: 'n', metaKey: true, shiftKey: true })
expect(screen.getByTestId('template-dialog'))!.toBeInTheDocument()
})
it('should not trigger create shortcut while typing in search', () => {
renderList()
fireEvent.keyDown(screen.getByRole('textbox'), { key: 'n', metaKey: true })
expect(screen.queryByTestId('create-app-modal'))!.not.toBeInTheDocument()
})
it('should not render create button for non-editors', () => {
mockIsCurrentWorkspaceEditor.mockReturnValue(false)

49
web/app/components/apps/app-list-header-filters.tsx
View File

@ -6,7 +6,7 @@ import { Button } from '@langgenius/dify-ui/button'
import { cn } from '@langgenius/dify-ui/cn'
import { DropdownMenu, DropdownMenuContent, DropdownMenuItem, DropdownMenuTrigger } from '@langgenius/dify-ui/dropdown-menu'
import { Select, SelectContent, SelectItem, SelectItemIndicator, SelectItemText, SelectTrigger } from '@langgenius/dify-ui/select'
import { useEffect, useMemo } from 'react'
import { useMemo } from 'react'
import { useTranslation } from 'react-i18next'
import Checkbox from '@/app/components/base/checkbox'
import Input from '@/app/components/base/input'
@ -35,14 +35,6 @@ type AppListHeaderFiltersProps = {
showCreateButton: boolean
}
const isEditableTarget = (target: EventTarget | null) => {
if (!(target instanceof HTMLElement))
return false
const tagName = target.tagName.toLowerCase()
return tagName === 'input' || tagName === 'textarea' || target.isContentEditable
}
const AppListHeaderFilters: FC<AppListHeaderFiltersProps> = ({
category,
tagIDs,
@ -68,36 +60,6 @@ const AppListHeaderFilters: FC<AppListHeaderFiltersProps> = ({
{ value: AppModeEnum.COMPLETION, text: t('types.completion', { ns: 'app' }), icon: <span className="mr-1 i-ri-file-4-line h-[14px] w-[14px]" /> },
], [t])
useEffect(() => {
if (!showCreateButton)
return
const handleKeyDown = (event: KeyboardEvent) => {
if (
event.defaultPrevented
|| event.repeat
|| event.altKey
|| isEditableTarget(event.target)
|| !(event.metaKey || event.ctrlKey)
|| event.key.toLowerCase() !== 'n'
) {
return
}
event.preventDefault()
if (event.shiftKey)
onCreateTemplate()
else
onCreateBlank()
}
window.addEventListener('keydown', handleKeyDown, { capture: true })
return () => {
window.removeEventListener('keydown', handleKeyDown, { capture: true })
}
}, [onCreateBlank, onCreateTemplate, showCreateButton])
return (
<div className="flex flex-wrap items-center justify-between gap-2 pt-2">
<div className="flex min-w-0 items-center gap-2">
@ -172,10 +134,6 @@ const AppListHeaderFilters: FC<AppListHeaderFiltersProps> = ({
>
<span aria-hidden className="i-ri-sticky-note-add-line size-4 shrink-0 text-text-secondary" />
<span className="min-w-0 flex-1 truncate px-1">{t('newApp.startFromBlank', { ns: 'app' })}</span>
<span className="flex shrink-0 items-center gap-0.5">
<kbd className="min-w-4 rounded bg-components-kbd-bg-gray px-px text-center system-kbd text-text-tertiary">⌘</kbd>
<kbd className="min-w-4 rounded bg-components-kbd-bg-gray px-px text-center system-kbd text-text-tertiary">N</kbd>
</span>
</DropdownMenuItem>
<DropdownMenuItem
className="h-8 gap-1 rounded-lg px-2 py-1 system-md-regular text-text-secondary"
@ -183,11 +141,6 @@ const AppListHeaderFilters: FC<AppListHeaderFiltersProps> = ({
>
<span aria-hidden className="i-ri-apps-2-add-line size-4 shrink-0 text-text-secondary" />
<span className="min-w-0 flex-1 truncate px-1">{t('newApp.startFromTemplate', { ns: 'app' })}</span>
<span className="flex shrink-0 items-center gap-0.5">
<kbd className="min-w-4 rounded bg-components-kbd-bg-gray px-px text-center system-kbd text-text-tertiary">⇧</kbd>
<kbd className="min-w-4 rounded bg-components-kbd-bg-gray px-px text-center system-kbd text-text-tertiary">⌘</kbd>
<kbd className="min-w-4 rounded bg-components-kbd-bg-gray px-px text-center system-kbd text-text-tertiary">N</kbd>
</span>
</DropdownMenuItem>
</div>
<div className="h-px bg-divider-subtle" />