From 4fbfedd287c6e8d91153b0a8e244ca19df9a0c35 Mon Sep 17 00:00:00 2001 From: Evan <2869018789@qq.com> Date: Fri, 26 Jun 2026 20:07:44 +0800 Subject: [PATCH] refactor: replace patch logger with caplog in test_version.py (#38029) --- api/tests/unit_tests/controllers/console/test_version.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/api/tests/unit_tests/controllers/console/test_version.py b/api/tests/unit_tests/controllers/console/test_version.py index 667e4f6f415..c17217b0187 100644 --- a/api/tests/unit_tests/controllers/console/test_version.py +++ b/api/tests/unit_tests/controllers/console/test_version.py @@ -65,7 +65,7 @@ class TestCheckVersionUpdate: assert result.features.can_replace_logo is True assert result.features.model_load_balancing_enabled is False - def test_http_error_fallback(self): + def test_http_error_fallback(self, caplog: pytest.LogCaptureFixture): query = version_module.VersionQuery(current_version="1.0.0") with ( @@ -79,15 +79,12 @@ class TestCheckVersionUpdate: "get", side_effect=Exception("boom"), ), - patch.object( - version_module.logger, - "warning", - ) as log_warning, + caplog.at_level(logging.WARNING, logger="controllers.console.version"), ): result = version_module.check_version_update(query) assert result.version == "1.0.0" - log_warning.assert_called_once() + assert "Check update version error" in caplog.text def test_new_version_available(self): query = version_module.VersionQuery(current_version="1.0.0")