fix: default selection issue & trigger retrieval setting unintentionally

This commit is contained in:
Yi
2024-09-28 14:13:02 +08:00
parent b92fced974
commit 69c0f3f2ad
5 changed files with 49 additions and 11 deletions

View File

@ -47,6 +47,11 @@ const DatasetItem: FC<Props> = ({
hideSettingsModal()
}, [hideSettingsModal, onChange])
const handleRemove = useCallback((e: React.MouseEvent) => {
e.stopPropagation()
onRemove()
}, [onRemove])
return (
<div className={`flex items-center h-10 justify-between rounded-xl px-2 border-[0.5px]
border-components-panel-border-subtle cursor-pointer group/dataset-item
@ -71,12 +76,15 @@ const DatasetItem: FC<Props> = ({
{!readonly && (
<div className='hidden group-hover/dataset-item:flex shrink-0 ml-2 items-center space-x-1'>
<ActionButton
onClick={showSettingsModal}
onClick={(e) => {
e.stopPropagation()
showSettingsModal()
}}
>
<RiEditLine className='w-4 h-4 flex-shrink-0 text-text-tertiary' />
</ActionButton>
<ActionButton
onClick={onRemove}
onClick={handleRemove}
state={ActionButtonState.Destructive}
onMouseEnter={() => setIsDeleteHovered(true)}
onMouseLeave={() => setIsDeleteHovered(false)}

View File

@ -208,6 +208,7 @@ const useConfig = (id: string, payload: KnowledgeRetrievalNodeType) => {
allEconomic,
mixtureHighQualityAndEconomic,
inconsistentEmbeddingModel,
allInternal,
} = getSelectedDatasetsMode(newDatasets)
const newInputs = produce(inputs, (draft) => {
draft.dataset_ids = newDatasets.map(d => d.id)
@ -220,7 +221,7 @@ const useConfig = (id: string, payload: KnowledgeRetrievalNodeType) => {
setInputs(newInputs)
setSelectedDatasets(newDatasets)
if (allEconomic || mixtureHighQualityAndEconomic || inconsistentEmbeddingModel)
if (allInternal && (allEconomic || mixtureHighQualityAndEconomic || inconsistentEmbeddingModel))
setRerankModelOpen(true)
}, [inputs, setInputs, payload.retrieval_mode])