youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-06 02:18:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: fix summary index bug.

Browse Source
This commit is contained in:
FFXN
2026-01-23 20:07:08 +08:00
parent b953e4fe9b
commit 76d18ca3dd
1 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
api/services/dataset_service.py
View File

@ -564,9 +564,6 @@ class DatasetService:
# Handle indexing technique changes and embedding model updates # Handle indexing technique changes and embedding model updates
action = DatasetService._handle_indexing_technique_change(dataset, data, filtered_data) action = DatasetService._handle_indexing_technique_change(dataset, data, filtered_data)
# Check if summary_index_setting model changed (before updating database)
summary_model_changed = DatasetService._check_summary_index_setting_model_changed(dataset, data)
# Add metadata fields # Add metadata fields
filtered_data["updated_by"] = user.id filtered_data["updated_by"] = user.id
filtered_data["updated_at"] = naive_utc_now() filtered_data["updated_at"] = naive_utc_now()
@ -601,13 +598,10 @@ class DatasetService:
regenerate_vectors_only=True, regenerate_vectors_only=True,
) )
# Trigger summary index regeneration if summary model changed # Note: summary_index_setting changes do not trigger automatic regeneration of existing summaries.
if summary_model_changed: # The new setting will only apply to:
regenerate_summary_index_task.delay( # 1. New documents added after the setting change
dataset.id, # 2. Manual summary generation requests
regenerate_reason="summary_model_changed",
regenerate_vectors_only=False,
)
return dataset return dataset
@ -904,14 +898,19 @@ class DatasetService:
new_summary_setting = data.get("summary_index_setting") new_summary_setting = data.get("summary_index_setting")
old_summary_setting = dataset.summary_index_setting old_summary_setting = dataset.summary_index_setting
# If old setting doesn't exist or is disabled, no need to regenerate
if not old_summary_setting or not old_summary_setting.get("enable"):
return False
# If new setting is disabled, no need to regenerate # If new setting is disabled, no need to regenerate
if not new_summary_setting or not new_summary_setting.get("enable"): if not new_summary_setting or not new_summary_setting.get("enable"):
return False return False
# If old setting doesn't exist, no need to regenerate (no existing summaries to regenerate)
# Note: This task only regenerates existing summaries, not generates new ones
if not old_summary_setting:
return False
# If old setting was disabled, no need to regenerate (no existing summaries to regenerate)
if not old_summary_setting.get("enable"):
return False
# Compare model_name and model_provider_name # Compare model_name and model_provider_name
old_model_name = old_summary_setting.get("model_name") old_model_name = old_summary_setting.get("model_name")
old_model_provider = old_summary_setting.get("model_provider_name") old_model_provider = old_summary_setting.get("model_provider_name")