refactor(api): refactor all

- Replaced direct imports of `TriggerProviderID` and `ToolProviderID` from `core.plugin.entities.plugin` with imports from `models.provider_ids` for better organization.
- Refactored workflow node classes to inherit from a unified `Node` class, improving consistency and maintainability.
- Removed unused code and comments to clean up the implementation, particularly in the `workflow_trigger.py` and `builtin_tools_manage_service.py` files.

These changes enhance the clarity and structure of the codebase, facilitating easier future modifications.

api/core/app/apps/workflow/app_runner.py

@@ -1,6 +1,6 @@
 import logging
 import time
-from typing import cast
+from typing import Optional, cast
 
 from core.app.apps.base_app_queue_manager import AppQueueManager
 from core.app.apps.workflow.app_config_manager import WorkflowAppConfig

api/core/entities/provider_entities.py

@@ -1,5 +1,5 @@
 from enum import StrEnum, auto
-from typing import Union
+from typing import Optional, Union
 
 from pydantic import BaseModel, ConfigDict, Field
 

api/core/helper/name_generator.py

@@ -3,7 +3,7 @@ import re
 from collections.abc import Sequence
 from typing import Any
 
-from core.tools.entities.tool_entities import CredentialType
+from core.plugin.entities.plugin_daemon import CredentialType
 
 logger = logging.getLogger(__name__)
 

api/core/plugin/entities/plugin.py

@@ -1,7 +1,7 @@
 import datetime
 from collections.abc import Mapping
 from enum import StrEnum, auto
-from typing import Any
+from typing import Any, Optional
 
 from packaging.version import InvalidVersion, Version
 from pydantic import BaseModel, Field, field_validator, model_validator

api/core/plugin/impl/tool.py

@@ -8,8 +8,6 @@ from core.plugin.entities.plugin_daemon import CredentialType, PluginBasicBoolea
 from core.plugin.impl.base import BasePluginClient
 from core.plugin.utils.chunk_merger import merge_blob_chunks
 from core.schemas.resolver import resolve_dify_schema_refs
-
-# from core.tools.entities.tool_entities import CredentialType, ToolInvokeMessage, ToolParameter
 from core.tools.entities.tool_entities import ToolInvokeMessage, ToolParameter
 from models.provider_ids import GenericProviderID, ToolProviderID
 

api/core/plugin/impl/trigger.py

@@ -4,7 +4,6 @@ from typing import Any
 
 from flask import Request
 
-from core.plugin.entities.plugin import GenericProviderID, TriggerProviderID
 from core.plugin.entities.plugin_daemon import CredentialType, PluginTriggerProviderEntity
 from core.plugin.entities.request import (
     PluginTriggerDispatchResponse,
@@ -16,6 +15,7 @@ from core.plugin.entities.request import (
 from core.plugin.impl.base import BasePluginClient
 from core.plugin.utils.http_parser import deserialize_response, serialize_request
 from core.trigger.entities.entities import Subscription
+from models.provider_ids import GenericProviderID, TriggerProviderID
 
 
 class PluginTriggerManager(BasePluginClient):

api/core/trigger/provider.py

@@ -9,7 +9,6 @@ from typing import Any, Optional
 from flask import Request
 
 from core.entities.provider_entities import BasicProviderConfig
-from core.plugin.entities.plugin import TriggerProviderID
 from core.plugin.entities.plugin_daemon import CredentialType
 from core.plugin.entities.request import (
     TriggerDispatchResponse,
@@ -28,6 +27,7 @@ from core.trigger.entities.entities import (
     Unsubscription,
 )
 from core.trigger.errors import TriggerProviderCredentialValidationError
+from models.provider_ids import TriggerProviderID
 from services.plugin.plugin_service import PluginService
 
 logger = logging.getLogger(__name__)

api/core/trigger/trigger_manager.py

@@ -10,7 +10,6 @@ from typing import Any, Optional
 from flask import Request
 
 import contexts
-from core.plugin.entities.plugin import TriggerProviderID
 from core.plugin.entities.plugin_daemon import CredentialType
 from core.plugin.entities.request import Event, TriggerInvokeResponse
 from core.plugin.impl.exc import PluginInvokeError
@@ -22,6 +21,7 @@ from core.trigger.entities.entities import (
     Unsubscription,
 )
 from core.trigger.provider import PluginTriggerProviderController
+from models.provider_ids import TriggerProviderID
 
 logger = logging.getLogger(__name__)
 

api/core/workflow/enums.py

@@ -62,6 +62,16 @@ class NodeType(StrEnum):
     TRIGGER_SCHEDULE = "trigger-schedule"
     TRIGGER_PLUGIN = "trigger-plugin"
 
+    @property
+    def is_start_node(self) -> bool:
+        """Check if this node type can serve as a workflow entry point."""
+        return self in [
+            NodeType.START,
+            NodeType.TRIGGER_WEBHOOK,
+            NodeType.TRIGGER_SCHEDULE,
+            NodeType.TRIGGER_PLUGIN,
+        ]
+
 
 class NodeExecutionType(StrEnum):
     """Node execution type classification."""

api/core/workflow/nodes/trigger_plugin/entities.py

@@ -2,8 +2,8 @@ from typing import Any, Optional
 
 from pydantic import Field
 
+from core.workflow.enums import ErrorStrategy
 from core.workflow.nodes.base.entities import BaseNodeData, RetryConfig
-from core.workflow.nodes.enums import ErrorStrategy
 
 
 class PluginTriggerData(BaseNodeData):

api/core/workflow/nodes/trigger_plugin/trigger_plugin_node.py

@@ -1,16 +1,16 @@
 from collections.abc import Mapping
 from typing import Any, Optional
 
-from core.workflow.entities.node_entities import NodeRunResult
 from core.workflow.entities.workflow_node_execution import WorkflowNodeExecutionMetadataKey, WorkflowNodeExecutionStatus
-from core.workflow.nodes.base import BaseNode
+from core.workflow.enums import ErrorStrategy, NodeType
+from core.workflow.node_events import NodeRunResult
 from core.workflow.nodes.base.entities import BaseNodeData, RetryConfig
-from core.workflow.nodes.enums import ErrorStrategy, NodeType
+from core.workflow.nodes.base.node import Node
 
 from .entities import PluginTriggerData
 
 
-class TriggerPluginNode(BaseNode):
+class TriggerPluginNode(Node):
     _node_type = NodeType.TRIGGER_PLUGIN
 
     _node_data: PluginTriggerData

api/core/workflow/nodes/trigger_schedule/trigger_schedule_node.py

@@ -2,15 +2,15 @@ from collections.abc import Mapping
 from datetime import UTC, datetime
 from typing import Any, Optional
 
-from core.workflow.entities.node_entities import NodeRunResult
 from core.workflow.entities.workflow_node_execution import WorkflowNodeExecutionStatus
-from core.workflow.nodes.base import BaseNode
+from core.workflow.enums import ErrorStrategy, NodeType
+from core.workflow.node_events import NodeRunResult
 from core.workflow.nodes.base.entities import BaseNodeData, RetryConfig
-from core.workflow.nodes.enums import ErrorStrategy, NodeType
+from core.workflow.nodes.base.node import Node
 from core.workflow.nodes.trigger_schedule.entities import TriggerScheduleNodeData
 
 
-class TriggerScheduleNode(BaseNode):
+class TriggerScheduleNode(Node):
     _node_type = NodeType.TRIGGER_SCHEDULE
 
     _node_data: TriggerScheduleNodeData

api/core/workflow/nodes/trigger_webhook/node.py

@@ -1,16 +1,16 @@
 from collections.abc import Mapping
 from typing import Any, Optional
 
-from core.workflow.entities.node_entities import NodeRunResult
 from core.workflow.entities.workflow_node_execution import WorkflowNodeExecutionStatus
-from core.workflow.nodes.base import BaseNode
+from core.workflow.enums import ErrorStrategy, NodeType
+from core.workflow.node_events import NodeRunResult
 from core.workflow.nodes.base.entities import BaseNodeData, RetryConfig
-from core.workflow.nodes.enums import ErrorStrategy, NodeType
+from core.workflow.nodes.base.node import Node
 
 from .entities import ContentType, WebhookData
 
 
-class TriggerWebhookNode(BaseNode):
+class TriggerWebhookNode(Node):
     _node_type = NodeType.TRIGGER_WEBHOOK
 
     _node_data: WebhookData