diff --git a/web/app/components/app/create-from-dsl-modal/__tests__/uploader.spec.tsx b/web/app/components/app/create-from-dsl-modal/__tests__/uploader.spec.tsx index ba097b355c..0240136d3e 100644 --- a/web/app/components/app/create-from-dsl-modal/__tests__/uploader.spec.tsx +++ b/web/app/components/app/create-from-dsl-modal/__tests__/uploader.spec.tsx @@ -157,7 +157,7 @@ describe('Uploader', () => { const hiddenInput = getHiddenInput() const clickSpy = vi.spyOn(hiddenInput, 'click') - fireEvent.click(screen.getByText('dslUploader.browse')) + fireEvent.click(screen.getByRole('button', { name: 'dslUploader.browse' })) expect(clickSpy).toHaveBeenCalled() diff --git a/web/app/components/app/create-from-dsl-modal/uploader.tsx b/web/app/components/app/create-from-dsl-modal/uploader.tsx index aeecb280d0..5b380bd9c5 100644 --- a/web/app/components/app/create-from-dsl-modal/uploader.tsx +++ b/web/app/components/app/create-from-dsl-modal/uploader.tsx @@ -112,7 +112,13 @@ const Uploader: FC = ({
{t('dslUploader.button', { ns: 'app' })} - {t('dslUploader.browse', { ns: 'app' })} +
{dragging &&
} diff --git a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/index.spec.tsx b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/index.spec.tsx index b5c73f3422..2021320616 100644 --- a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/index.spec.tsx +++ b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/index.spec.tsx @@ -1352,7 +1352,7 @@ describe('Uploader', () => { ) expect(screen.getByText('app.dslUploader.button'))!.toBeInTheDocument() - expect(screen.getByText('app.dslUploader.browse'))!.toBeInTheDocument() + expect(screen.getByRole('button', { name: 'app.dslUploader.browse' }))!.toBeInTheDocument() }) it('should render file info when file is selected', () => { @@ -1436,7 +1436,7 @@ describe('Uploader', () => { />, ) - const browseLink = screen.getByText('app.dslUploader.browse') + const browseLink = screen.getByRole('button', { name: 'app.dslUploader.browse' }) const fileInput = document.querySelector('input[type="file"]') as HTMLInputElement // Mock click on input @@ -1659,7 +1659,7 @@ describe('Uploader', () => { // After click, oncancel should be set }) - const browseLink = screen.getByText('app.dslUploader.browse') + const browseLink = screen.getByRole('button', { name: 'app.dslUploader.browse' }) fireEvent.click(browseLink) // selectHandle should have triggered click on input diff --git a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/uploader.spec.tsx b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/uploader.spec.tsx index f4263ab439..bab1d505b7 100644 --- a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/uploader.spec.tsx +++ b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/__tests__/uploader.spec.tsx @@ -50,7 +50,7 @@ describe('Uploader', () => { it('should render browse link when no file', () => { render() - expect(screen.getByText(/dslUploader\.browse/i)).toBeInTheDocument() + expect(screen.getByRole('button', { name: /dslUploader\.browse/i })).toBeInTheDocument() }) it('should render upload icon when no file', () => { @@ -108,7 +108,7 @@ describe('Uploader', () => { const input = document.getElementById('fileUploader') as HTMLInputElement const clickSpy = vi.spyOn(input, 'click') - const browseLink = screen.getByText(/dslUploader\.browse/i) + const browseLink = screen.getByRole('button', { name: /dslUploader\.browse/i }) fireEvent.click(browseLink) expect(clickSpy).toHaveBeenCalled() diff --git a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx index f0499c6965..9b4cf2c488 100644 --- a/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx +++ b/web/app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx @@ -90,9 +90,13 @@ const Uploader: FC = ({ file, updateFile, className }) => {
{t('dslUploader.button', { ns: 'app' })} - +
{dragging &&
}