refactor(api): Unify Human Input handling logic

api/tests/unit_tests/services/workflow/test_workflow_service.py

@@ -1,9 +1,15 @@
+from contextlib import nullcontext
+from types import SimpleNamespace
 from unittest.mock import MagicMock
 
 import pytest
 
+from core.workflow.enums import NodeType
+from core.workflow.nodes.human_input.entities import FormInput, HumanInputNodeData, UserAction
+from core.workflow.nodes.human_input.enums import FormInputType
 from models.model import App
 from models.workflow import Workflow
+from services import workflow_service as workflow_service_module
 from services.workflow_service import WorkflowService
 
 
@@ -161,3 +167,111 @@ class TestWorkflowService:
         assert workflows == []
         assert has_more is False
         mock_session.scalars.assert_called_once()
+
+    def test_submit_human_input_form_preview_uses_rendered_content(
+        self, workflow_service: WorkflowService, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        service = workflow_service
+        node_data = HumanInputNodeData(
+            title="Human Input",
+            form_content="<p>{{#$output.name#}}</p>",
+            inputs=[FormInput(type=FormInputType.TEXT_INPUT, output_variable_name="name")],
+            user_actions=[UserAction(id="approve", title="Approve")],
+        )
+        node = MagicMock()
+        node.node_data = node_data
+        node._render_form_content_before_submission.return_value = "<p>preview</p>"
+        node._render_form_content_with_outputs.return_value = "<p>rendered</p>"
+
+        service._build_human_input_variable_pool = MagicMock(return_value=MagicMock())  # type: ignore[method-assign]
+        service._build_human_input_node = MagicMock(return_value=node)  # type: ignore[method-assign]
+
+        workflow = MagicMock()
+        workflow.get_node_config_by_id.return_value = {"id": "node-1", "data": {"type": NodeType.HUMAN_INPUT.value}}
+        workflow.get_enclosing_node_type_and_id.return_value = None
+        service.get_draft_workflow = MagicMock(return_value=workflow)  # type: ignore[method-assign]
+
+        saved_outputs: dict[str, object] = {}
+
+        class DummySession:
+            def __init__(self, *args, **kwargs):
+                self.commit = MagicMock()
+
+            def __enter__(self):
+                return self
+
+            def __exit__(self, exc_type, exc, tb):
+                return False
+
+            def begin(self):
+                return nullcontext()
+
+        class DummySaver:
+            def __init__(self, *args, **kwargs):
+                pass
+
+            def save(self, outputs, process_data):
+                saved_outputs.update(outputs)
+
+        monkeypatch.setattr(workflow_service_module, "Session", DummySession)
+        monkeypatch.setattr(workflow_service_module, "DraftVariableSaver", DummySaver)
+        monkeypatch.setattr(workflow_service_module, "db", SimpleNamespace(engine=MagicMock()))
+
+        app_model = SimpleNamespace(id="app-1", tenant_id="tenant-1")
+        account = SimpleNamespace(id="account-1")
+
+        result = service.submit_human_input_form_preview(
+            app_model=app_model,
+            account=account,
+            node_id="node-1",
+            form_inputs={"name": "Ada", "extra": "ignored"},
+            action="approve",
+        )
+
+        node._render_form_content_with_outputs.assert_called_once()
+        called_args = node._render_form_content_with_outputs.call_args.args
+        assert called_args[0] == "<p>preview</p>"
+        assert called_args[2] == node_data.outputs_field_names()
+        rendered_outputs = called_args[1]
+        assert rendered_outputs["name"] == "Ada"
+        assert rendered_outputs["extra"] == "ignored"
+        assert "extra" in saved_outputs
+        assert "extra" in result
+        assert saved_outputs["name"] == "Ada"
+        assert result["name"] == "Ada"
+        assert result["__action_id"] == "approve"
+        assert "__rendered_content" in result
+
+    def test_submit_human_input_form_preview_missing_inputs_message(self, workflow_service: WorkflowService) -> None:
+        service = workflow_service
+        node_data = HumanInputNodeData(
+            title="Human Input",
+            form_content="<p>{{#$output.name#}}</p>",
+            inputs=[FormInput(type=FormInputType.TEXT_INPUT, output_variable_name="name")],
+            user_actions=[UserAction(id="approve", title="Approve")],
+        )
+        node = MagicMock()
+        node.node_data = node_data
+        node._render_form_content_before_submission.return_value = "<p>preview</p>"
+        node._render_form_content_with_outputs.return_value = "<p>rendered</p>"
+
+        service._build_human_input_variable_pool = MagicMock(return_value=MagicMock())  # type: ignore[method-assign]
+        service._build_human_input_node = MagicMock(return_value=node)  # type: ignore[method-assign]
+
+        workflow = MagicMock()
+        workflow.get_node_config_by_id.return_value = {"id": "node-1", "data": {"type": NodeType.HUMAN_INPUT.value}}
+        service.get_draft_workflow = MagicMock(return_value=workflow)  # type: ignore[method-assign]
+
+        app_model = SimpleNamespace(id="app-1", tenant_id="tenant-1")
+        account = SimpleNamespace(id="account-1")
+
+        with pytest.raises(ValueError) as exc_info:
+            service.submit_human_input_form_preview(
+                app_model=app_model,
+                account=account,
+                node_id="node-1",
+                form_inputs={},
+                action="approve",
+            )
+
+        assert "Missing required inputs" in str(exc_info.value)