refactor: replace BuiltinToolManageService with RagPipelineManageService for datasource management and remove unused datasource engine and related code

This commit is contained in:
Yeuoly
2025-05-16 18:42:07 +08:00
parent 8bea88c8cc
commit c5a2f43ceb
22 changed files with 390 additions and 1496 deletions

View File

@ -5,7 +5,6 @@ from pathlib import Path
from sqlalchemy.orm import Session
from configs import dify_config
from core.datasource.entities.api_entities import DatasourceProviderApiEntity
from core.helper.position_helper import is_filtered
from core.model_runtime.utils.encoders import jsonable_encoder
from core.plugin.entities.plugin import GenericProviderID, ToolProviderID
@ -17,7 +16,7 @@ from core.tools.tool_label_manager import ToolLabelManager
from core.tools.tool_manager import ToolManager
from core.tools.utils.configuration import ProviderConfigEncrypter
from extensions.ext_database import db
from models.tools import BuiltinDatasourceProvider, BuiltinToolProvider
from models.tools import BuiltinToolProvider
from services.tools.tools_transform_service import ToolTransformService
logger = logging.getLogger(__name__)
@ -287,67 +286,6 @@ class BuiltinToolManageService:
return BuiltinToolProviderSort.sort(result)
@staticmethod
def list_rag_pipeline_datasources(tenant_id: str) -> list[DatasourceProviderApiEntity]:
"""
list rag pipeline datasources
"""
# get all builtin providers
datasource_provider_controllers = ToolManager.list_datasource_providers(tenant_id)
with db.session.no_autoflush:
# get all user added providers
db_providers: list[BuiltinDatasourceProvider] = (
db.session.query(BuiltinDatasourceProvider)
.filter(BuiltinDatasourceProvider.tenant_id == tenant_id)
.all()
or []
)
# find provider
def find_provider(provider):
return next(filter(lambda db_provider: db_provider.provider == provider, db_providers), None)
result: list[DatasourceProviderApiEntity] = []
for provider_controller in datasource_provider_controllers:
try:
# handle include, exclude
if is_filtered(
include_set=dify_config.POSITION_TOOL_INCLUDES_SET, # type: ignore
exclude_set=dify_config.POSITION_TOOL_EXCLUDES_SET, # type: ignore
data=provider_controller,
name_func=lambda x: x.identity.name,
):
continue
# convert provider controller to user provider
user_builtin_provider = ToolTransformService.builtin_datasource_provider_to_user_provider(
provider_controller=provider_controller,
db_provider=find_provider(provider_controller.entity.identity.name),
decrypt_credentials=True,
)
# add icon
ToolTransformService.repack_provider(tenant_id=tenant_id, provider=user_builtin_provider)
datasources = provider_controller.get_datasources()
for datasource in datasources or []:
user_builtin_provider.datasources.append(
ToolTransformService.convert_datasource_entity_to_api_entity(
tenant_id=tenant_id,
datasource=datasource,
credentials=user_builtin_provider.original_credentials,
labels=ToolLabelManager.get_tool_labels(provider_controller),
)
)
result.append(user_builtin_provider)
except Exception as e:
raise e
return result
@staticmethod
def _fetch_builtin_provider(provider_name: str, tenant_id: str) -> BuiltinToolProvider | None:
try:

View File

@ -5,11 +5,6 @@ from typing import Optional, Union, cast
from yarl import URL
from configs import dify_config
from core.datasource.__base.datasource_plugin import DatasourcePlugin
from core.datasource.__base.datasource_provider import DatasourcePluginProviderController
from core.datasource.__base.datasource_runtime import DatasourceRuntime
from core.datasource.entities.api_entities import DatasourceApiEntity, DatasourceProviderApiEntity
from core.datasource.entities.datasource_entities import DatasourceProviderType
from core.tools.__base.tool import Tool
from core.tools.__base.tool_runtime import ToolRuntime
from core.tools.builtin_tool.provider import BuiltinToolProviderController
@ -26,7 +21,7 @@ from core.tools.plugin_tool.provider import PluginToolProviderController
from core.tools.utils.configuration import ProviderConfigEncrypter
from core.tools.workflow_as_tool.provider import WorkflowToolProviderController
from core.tools.workflow_as_tool.tool import WorkflowTool
from models.tools import ApiToolProvider, BuiltinDatasourceProvider, BuiltinToolProvider, WorkflowToolProvider
from models.tools import ApiToolProvider, BuiltinToolProvider, WorkflowToolProvider
logger = logging.getLogger(__name__)
@ -145,64 +140,6 @@ class ToolTransformService:
return result
@classmethod
def builtin_datasource_provider_to_user_provider(
cls,
provider_controller: DatasourcePluginProviderController,
db_provider: Optional[BuiltinDatasourceProvider],
decrypt_credentials: bool = True,
) -> DatasourceProviderApiEntity:
"""
convert provider controller to user provider
"""
result = DatasourceProviderApiEntity(
id=provider_controller.entity.identity.name,
author=provider_controller.entity.identity.author,
name=provider_controller.entity.identity.name,
description=provider_controller.entity.identity.description,
icon=provider_controller.entity.identity.icon,
label=provider_controller.entity.identity.label,
type=DatasourceProviderType.RAG_PIPELINE,
masked_credentials={},
is_team_authorization=False,
plugin_id=provider_controller.plugin_id,
plugin_unique_identifier=provider_controller.plugin_unique_identifier,
datasources=[],
)
# get credentials schema
schema = {x.to_basic_provider_config().name: x for x in provider_controller.get_credentials_schema()}
for name, value in schema.items():
if result.masked_credentials:
result.masked_credentials[name] = ""
# check if the provider need credentials
if not provider_controller.need_credentials:
result.is_team_authorization = True
result.allow_delete = False
elif db_provider:
result.is_team_authorization = True
if decrypt_credentials:
credentials = db_provider.credentials
# init tool configuration
tool_configuration = ProviderConfigEncrypter(
tenant_id=db_provider.tenant_id,
config=[x.to_basic_provider_config() for x in provider_controller.get_credentials_schema()],
provider_type=provider_controller.provider_type.value,
provider_identity=provider_controller.entity.identity.name,
)
# decrypt the credentials and mask the credentials
decrypted_credentials = tool_configuration.decrypt(data=credentials)
masked_credentials = tool_configuration.mask_tool_credentials(data=decrypted_credentials)
result.masked_credentials = masked_credentials
result.original_credentials = decrypted_credentials
return result
@staticmethod
def api_provider_to_controller(
db_provider: ApiToolProvider,
@ -367,48 +304,3 @@ class ToolTransformService:
parameters=tool.parameters,
labels=labels or [],
)
@staticmethod
def convert_datasource_entity_to_api_entity(
datasource: DatasourcePlugin,
tenant_id: str,
credentials: dict | None = None,
labels: list[str] | None = None,
) -> DatasourceApiEntity:
"""
convert tool to user tool
"""
# fork tool runtime
datasource = datasource.fork_datasource_runtime(
runtime=DatasourceRuntime(
credentials=credentials or {},
tenant_id=tenant_id,
)
)
# get datasource parameters
parameters = datasource.entity.parameters or []
# get datasource runtime parameters
runtime_parameters = datasource.get_runtime_parameters()
# override parameters
current_parameters = parameters.copy()
for runtime_parameter in runtime_parameters:
found = False
for index, parameter in enumerate(current_parameters):
if parameter.name == runtime_parameter.name and parameter.form == runtime_parameter.form:
current_parameters[index] = runtime_parameter
found = True
break
if not found and runtime_parameter.form == ToolParameter.ToolParameterForm.FORM:
current_parameters.append(runtime_parameter)
return DatasourceApiEntity(
author=datasource.entity.identity.author,
name=datasource.entity.identity.name,
label=datasource.entity.identity.label,
description=datasource.entity.description.human if datasource.entity.description else I18nObject(en_US=""),
output_schema=datasource.entity.output_schema,
parameters=current_parameters,
labels=labels or [],
)