refactor(api): enhance request handling and time management

- Initialized `response` variable in `trigger.py` to ensure proper handling in the trigger endpoint.
- Updated `http_parser.py` to conditionally set `CONTENT_TYPE` and `CONTENT_LENGTH` headers for improved robustness.
- Changed `datetime.utcnow()` to `datetime.now(UTC)` in `sqlalchemy_workflow_trigger_log_repository.py` and `rate_limiter.py` for consistent time zone handling.
- Refactored `async_workflow_service.py` to use the public method `get_tenant_owner_timezone` for better encapsulation.
- Simplified subscription retrieval logic in `plugin_parameter_service.py` for clarity.

These changes improve code reliability and maintainability while ensuring accurate time management and request processing.
This commit is contained in:
Harry
2025-09-25 19:46:52 +08:00
parent 452588dded
commit d5ff89f6d3
7 changed files with 31 additions and 22 deletions

View File

@ -131,7 +131,7 @@ class AsyncWorkflowService:
trigger_log_repo.update(trigger_log)
session.commit()
tenant_owner_tz = rate_limiter._get_tenant_owner_timezone(trigger_data.tenant_id)
tenant_owner_tz = rate_limiter.get_tenant_owner_timezone(trigger_data.tenant_id)
remaining = rate_limiter.get_remaining_quota(trigger_data.tenant_id, dispatcher.get_daily_limit())

View File

@ -85,15 +85,14 @@ class PluginParameterService:
credential_type = db_record.credential_type
case "trigger":
provider_controller = TriggerManager.get_trigger_provider(tenant_id, TriggerProviderID(provider))
subscription: TriggerProviderSubscriptionApiEntity | SubscriptionBuilder | None
if credential_id:
subscription: TriggerProviderSubscriptionApiEntity | SubscriptionBuilder | None = (
subscription = (
TriggerSubscriptionBuilderService.get_subscription_builder(credential_id)
or TriggerProviderService.get_subscription_by_id(tenant_id, credential_id)
)
else:
subscription: TriggerProviderSubscriptionApiEntity | SubscriptionBuilder | None = (
TriggerProviderService.get_subscription_by_id(tenant_id)
)
subscription = TriggerProviderService.get_subscription_by_id(tenant_id)
if subscription is None:
raise ValueError(f"Subscription {credential_id} not found")

View File

@ -30,7 +30,7 @@ class TenantDailyRateLimiter:
def __init__(self, redis_client: Union[Redis, RedisClientWrapper]):
self.redis = redis_client
def _get_tenant_owner_timezone(self, tenant_id: str) -> str:
def get_tenant_owner_timezone(self, tenant_id: str) -> str:
"""
Get timezone of tenant owner
@ -62,7 +62,7 @@ class TenantDailyRateLimiter:
Returns:
Redis key for the current UTC day
"""
utc_now = datetime.utcnow()
utc_now = datetime.now(UTC)
date_str = utc_now.strftime("%Y-%m-%d")
return f"workflow:daily_limit:{tenant_id}:{date_str}"
@ -73,7 +73,7 @@ class TenantDailyRateLimiter:
Returns:
Number of seconds until UTC midnight
"""
utc_now = datetime.utcnow()
utc_now = datetime.now(UTC)
# Get next midnight in UTC
next_midnight = datetime.combine(utc_now.date() + timedelta(days=1), time.min)