Revert "refactor!: replace Zustand global store with TanStack Query for systemFeatures"

This reverts commit 806ece9a67.

web/app/components/plugins/plugin-page/context.spec.tsx

@@ -1,7 +1,7 @@
 import { render, screen } from '@testing-library/react'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 // Import mocks
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 
 import { PluginPageContext, PluginPageContextProvider, usePluginPageContext } from './context'
 
@@ -11,7 +11,7 @@ vi.mock('nuqs', () => ({
 }))
 
 vi.mock('@/context/global-public-context', () => ({
-  useSystemFeatures: vi.fn(),
+  useGlobalPublicStore: vi.fn(),
 }))
 
 vi.mock('../hooks', () => ({
@@ -25,11 +25,12 @@ vi.mock('../hooks', () => ({
   ],
 }))
 
-// Helper function to mock useSystemFeatures with marketplace setting
+// Helper function to mock useGlobalPublicStore with marketplace setting
 const mockGlobalPublicStore = (enableMarketplace: boolean) => {
-  vi.mocked(useSystemFeatures).mockReturnValue({
-    enable_marketplace: enableMarketplace,
-  } as ReturnType<typeof useSystemFeatures>)
+  vi.mocked(useGlobalPublicStore).mockImplementation((selector) => {
+    const state = { systemFeatures: { enable_marketplace: enableMarketplace } }
+    return selector(state as Parameters<typeof selector>[0])
+  })
 }
 
 // Test component that uses the context

web/app/components/plugins/plugin-page/context.tsx

@@ -13,7 +13,7 @@ import {
   createContext,
   useContextSelector,
 } from 'use-context-selector'
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 import { PLUGIN_PAGE_TABS_MAP, usePluginPageTabs } from '../hooks'
 
 export type PluginPageContextValue = {
@@ -63,7 +63,7 @@ export const PluginPageContextProvider = ({
   })
   const [currentPluginID, setCurrentPluginID] = useState<string | undefined>()
 
-  const { enable_marketplace } = useSystemFeatures()
+  const { enable_marketplace } = useGlobalPublicStore(s => s.systemFeatures)
   const tabs = usePluginPageTabs()
   const options = useMemo(() => {
     return enable_marketplace ? tabs : tabs.filter(tab => tab.value !== PLUGIN_PAGE_TABS_MAP.marketplace)

web/app/components/plugins/plugin-page/empty/index.spec.tsx

@@ -56,10 +56,14 @@ vi.mock('../context', () => ({
 
 // Mock global public store (Zustand store)
 vi.mock('@/context/global-public-context', () => ({
-  useSystemFeatures: () => ({
-    ...defaultSystemFeatures,
-    ...mockState.systemFeatures,
-  }),
+  useGlobalPublicStore: (selector: (state: any) => any) => {
+    return selector({
+      systemFeatures: {
+        ...defaultSystemFeatures,
+        ...mockState.systemFeatures,
+      },
+    })
+  },
 }))
 
 // Mock useInstalledPluginList hook

web/app/components/plugins/plugin-page/empty/index.tsx

@@ -11,7 +11,7 @@ import { MagicBox } from '@/app/components/base/icons/src/vender/solid/mediaAndD
 import InstallFromGitHub from '@/app/components/plugins/install-plugin/install-from-github'
 import InstallFromLocalPackage from '@/app/components/plugins/install-plugin/install-from-local-package'
 import { SUPPORT_INSTALL_LOCAL_FILE_EXTENSIONS } from '@/config'
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 import { useInstalledPluginList } from '@/service/use-plugins'
 import Line from '../../marketplace/empty/line'
 import { usePluginPageContext } from '../context'
@@ -27,7 +27,7 @@ const Empty = () => {
   const fileInputRef = useRef<HTMLInputElement>(null)
   const [selectedAction, setSelectedAction] = useState<string | null>(null)
   const [selectedFile, setSelectedFile] = useState<File | null>(null)
-  const { enable_marketplace, plugin_installation_permission } = useSystemFeatures()
+  const { enable_marketplace, plugin_installation_permission } = useGlobalPublicStore(s => s.systemFeatures)
   const setActiveTab = usePluginPageContext(v => v.setActiveTab)
 
   const handleFileChange = (event: React.ChangeEvent<HTMLInputElement>) => {

web/app/components/plugins/plugin-page/index.spec.tsx

@@ -28,9 +28,14 @@ vi.mock('@/context/i18n', () => ({
 }))
 
 vi.mock('@/context/global-public-context', () => ({
-  useSystemFeatures: vi.fn(() => ({
-    enable_marketplace: true,
-  })),
+  useGlobalPublicStore: vi.fn((selector) => {
+    const state = {
+      systemFeatures: {
+        enable_marketplace: true,
+      },
+    }
+    return selector(state)
+  }),
 }))
 
 vi.mock('@/context/app-context', () => ({
@@ -624,9 +629,14 @@ describe('PluginPage Component', () => {
     it('should handle marketplace disabled', () => {
       // Mock marketplace disabled
       vi.mock('@/context/global-public-context', async () => ({
-        useSystemFeatures: vi.fn(() => ({
-          enable_marketplace: false,
-        })),
+        useGlobalPublicStore: vi.fn((selector) => {
+          const state = {
+            systemFeatures: {
+              enable_marketplace: false,
+            },
+          }
+          return selector(state)
+        }),
       }))
 
       vi.mocked(useQueryState).mockReturnValue(['discover', vi.fn()])

web/app/components/plugins/plugin-page/index.tsx

@@ -16,9 +16,9 @@ import TabSlider from '@/app/components/base/tab-slider'
 import Tooltip from '@/app/components/base/tooltip'
 import ReferenceSettingModal from '@/app/components/plugins/reference-setting-modal'
 import { MARKETPLACE_API_PREFIX, SUPPORT_INSTALL_LOCAL_FILE_EXTENSIONS } from '@/config'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 import { useDocLink } from '@/context/i18n'
 import useDocumentTitle from '@/hooks/use-document-title'
-import { useSystemFeatures } from '@/hooks/use-global-public'
 import { usePluginInstallation } from '@/hooks/use-query-params'
 import { fetchBundleInfoFromMarketPlace, fetchManifestFromMarketPlace } from '@/service/plugins'
 import { sleep } from '@/utils'
@@ -112,7 +112,7 @@ const PluginPage = ({
   const options = usePluginPageContext(v => v.options)
   const activeTab = usePluginPageContext(v => v.activeTab)
   const setActiveTab = usePluginPageContext(v => v.setActiveTab)
-  const { enable_marketplace } = useSystemFeatures()
+  const { enable_marketplace } = useGlobalPublicStore(s => s.systemFeatures)
 
   const isPluginsTab = useMemo(() => activeTab === PLUGIN_PAGE_TABS_MAP.plugins, [activeTab])
   const isExploringMarketplace = useMemo(() => {

web/app/components/plugins/plugin-page/install-plugin-dropdown.tsx

@@ -16,7 +16,7 @@ import {
 import InstallFromGitHub from '@/app/components/plugins/install-plugin/install-from-github'
 import InstallFromLocalPackage from '@/app/components/plugins/install-plugin/install-from-local-package'
 import { SUPPORT_INSTALL_LOCAL_FILE_EXTENSIONS } from '@/config'
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 import { cn } from '@/utils/classnames'
 
 type Props = {
@@ -37,7 +37,7 @@ const InstallPluginDropdown = ({
   const [isMenuOpen, setIsMenuOpen] = useState(false)
   const [selectedAction, setSelectedAction] = useState<string | null>(null)
   const [selectedFile, setSelectedFile] = useState<File | null>(null)
-  const { enable_marketplace, plugin_installation_permission } = useSystemFeatures()
+  const { enable_marketplace, plugin_installation_permission } = useGlobalPublicStore(s => s.systemFeatures)
 
   const handleFileChange = (event: React.ChangeEvent<HTMLInputElement>) => {
     const file = event.target.files?.[0]

web/app/components/plugins/plugin-page/use-reference-setting.spec.ts

@@ -2,7 +2,7 @@ import { renderHook, waitFor } from '@testing-library/react'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 // Import mocks for assertions
 import { useAppContext } from '@/context/app-context'
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 
 import { useInvalidateReferenceSettings, useMutationReferenceSettings, useReferenceSettings } from '@/service/use-plugins'
 import Toast from '../../base/toast'
@@ -21,7 +21,7 @@ vi.mock('@/context/app-context', () => ({
 }))
 
 vi.mock('@/context/global-public-context', () => ({
-  useSystemFeatures: vi.fn(),
+  useGlobalPublicStore: vi.fn(),
 }))
 
 vi.mock('@/service/use-plugins', () => ({
@@ -309,9 +309,14 @@ describe('useCanInstallPluginFromMarketplace Hook', () => {
   })
 
   it('should return true when marketplace is enabled and canManagement is true', () => {
-    vi.mocked(useSystemFeatures).mockReturnValue({
-      enable_marketplace: true,
-    } as ReturnType<typeof useSystemFeatures>)
+    vi.mocked(useGlobalPublicStore).mockImplementation((selector) => {
+      const state = {
+        systemFeatures: {
+          enable_marketplace: true,
+        },
+      }
+      return selector(state as Parameters<typeof selector>[0])
+    })
 
     const { result } = renderHook(() => useCanInstallPluginFromMarketplace())
 
@@ -319,9 +324,14 @@ describe('useCanInstallPluginFromMarketplace Hook', () => {
   })
 
   it('should return false when marketplace is disabled', () => {
-    vi.mocked(useSystemFeatures).mockReturnValue({
-      enable_marketplace: false,
-    } as ReturnType<typeof useSystemFeatures>)
+    vi.mocked(useGlobalPublicStore).mockImplementation((selector) => {
+      const state = {
+        systemFeatures: {
+          enable_marketplace: false,
+        },
+      }
+      return selector(state as Parameters<typeof selector>[0])
+    })
 
     const { result } = renderHook(() => useCanInstallPluginFromMarketplace())
 
@@ -329,9 +339,14 @@ describe('useCanInstallPluginFromMarketplace Hook', () => {
   })
 
   it('should return false when canManagement is false', () => {
-    vi.mocked(useSystemFeatures).mockReturnValue({
-      enable_marketplace: true,
-    } as ReturnType<typeof useSystemFeatures>)
+    vi.mocked(useGlobalPublicStore).mockImplementation((selector) => {
+      const state = {
+        systemFeatures: {
+          enable_marketplace: true,
+        },
+      }
+      return selector(state as Parameters<typeof selector>[0])
+    })
 
     vi.mocked(useReferenceSettings).mockReturnValue({
       data: {
@@ -348,9 +363,14 @@ describe('useCanInstallPluginFromMarketplace Hook', () => {
   })
 
   it('should return false when both marketplace is disabled and canManagement is false', () => {
-    vi.mocked(useSystemFeatures).mockReturnValue({
-      enable_marketplace: false,
-    } as ReturnType<typeof useSystemFeatures>)
+    vi.mocked(useGlobalPublicStore).mockImplementation((selector) => {
+      const state = {
+        systemFeatures: {
+          enable_marketplace: false,
+        },
+      }
+      return selector(state as Parameters<typeof selector>[0])
+    })
 
     vi.mocked(useReferenceSettings).mockReturnValue({
       data: {

web/app/components/plugins/plugin-page/use-reference-setting.ts

@@ -1,7 +1,7 @@
 import { useMemo } from 'react'
 import { useTranslation } from 'react-i18next'
 import { useAppContext } from '@/context/app-context'
-import { useSystemFeatures } from '@/hooks/use-global-public'
+import { useGlobalPublicStore } from '@/context/global-public-context'
 import { useInvalidateReferenceSettings, useMutationReferenceSettings, useReferenceSettings } from '@/service/use-plugins'
 import Toast from '../../base/toast'
 import { PermissionType } from '../types'
@@ -48,7 +48,7 @@ const useReferenceSetting = () => {
 }
 
 export const useCanInstallPluginFromMarketplace = () => {
-  const { enable_marketplace } = useSystemFeatures()
+  const { enable_marketplace } = useGlobalPublicStore(s => s.systemFeatures)
   const { canManagement } = useReferenceSetting()
 
   const canInstallPluginFromMarketplace = useMemo(() => {