youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-02 08:28:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: improve coverage for some files (#33218)

Browse Source
This commit is contained in:
Saumya Talwani
2026-03-12 12:39:10 +05:30
committed by GitHub
parent 68982f910e
commit ed5511ce28
61 changed files with 3191 additions and 304 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/app/components/datasets/documents/components/document-list/__tests__/index.spec.tsx
View File

@ -175,12 +175,11 @@ describe('DocumentList', () => {
...defaultProps,
selectedIds: ['doc-1', 'doc-2', 'doc-3'],
}
const { container } = render(<DocumentList {...props} />, { wrapper: createWrapper() })
render(<DocumentList {...props} />, { wrapper: createWrapper() })
const checkboxes = findCheckboxes(container)
// When checked, checkbox should have a check icon (svg) inside
checkboxes.forEach((checkbox) => {
const checkIcon = checkbox.querySelector('svg')
props.selectedIds.forEach((id) => {
const checkIcon = screen.getByTestId(`check-icon-doc-row-${id}`)
expect(checkIcon).toBeInTheDocument()
})
})

8
web/app/components/datasets/documents/components/document-list/components/__tests__/document-table-row.spec.tsx
View File

@ -126,20 +126,16 @@ describe('DocumentTableRow', () => {
describe('Selection', () => {
it('should show check icon when isSelected is true', () => {
const { container } = render(<DocumentTableRow {...defaultProps} isSelected />, { wrapper: createWrapper() })
// When selected, the checkbox should have a check icon (RiCheckLine svg)
const checkbox = findCheckbox(container)
expect(checkbox).toBeInTheDocument()
const checkIcon = checkbox?.querySelector('svg')
expect(checkIcon).toBeInTheDocument()
expect(screen.getByTestId('check-icon-doc-row-doc-1')).toBeInTheDocument()
})
it('should not show check icon when isSelected is false', () => {
const { container } = render(<DocumentTableRow {...defaultProps} isSelected={false} />, { wrapper: createWrapper() })
const checkbox = findCheckbox(container)
expect(checkbox).toBeInTheDocument()
// When not selected, there should be no check icon inside the checkbox
const checkIcon = checkbox?.querySelector('svg')
expect(checkIcon).not.toBeInTheDocument()
expect(screen.queryByTestId('check-icon-doc-row-doc-1')).not.toBeInTheDocument()
})
it('should call onSelectOne when checkbox is clicked', () => {

1
web/app/components/datasets/documents/components/document-list/components/document-table-row.tsx
View File

@ -91,6 +91,7 @@ const DocumentTableRow: FC<DocumentTableRowProps> = React.memo(({
className="mr-2 shrink-0"
checked={isSelected}
onCheck={() => onSelectOne(doc.id)}
id={`doc-row-${doc.id}`}
/>
{index + 1}
</div>

6
web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/list/item.tsx
View File

@ -42,7 +42,7 @@ const Item = ({
}
: {}
const handleSelect = useCallback((e: React.MouseEvent<HTMLDivElement>) => {
const handleSelect = useCallback((e: React.MouseEvent<HTMLDivElement> | React.KeyboardEvent<HTMLDivElement>) => {
e.stopPropagation()
onSelect(file)
}, [file, onSelect])
@ -91,13 +91,13 @@ const Item = ({
>
<FileIcon type={type} fileName={name} className="shrink-0 transform-gpu" />
<span
className="system-sm-medium grow truncate text-text-secondary"
className="grow truncate text-text-secondary system-sm-medium"
title={name}
>
{name}
</span>
{!isFolder && typeof size === 'number' && (
<span className="system-xs-regular shrink-0 text-text-tertiary">{formatFileSize(size)}</span>
<span className="shrink-0 text-text-tertiary system-xs-regular">{formatFileSize(size)}</span>
)}
</div>
</Wrapper>