feat(trigger): enhance trigger management with new error handling and response structure

- Added `TriggerInvokeError` and `TriggerIgnoreEventError` for better error categorization during trigger invocation.
- Updated `TriggerInvokeResponse` to include a `cancelled` field, indicating if a trigger was ignored.
- Enhanced `TriggerManager` to handle specific errors and return appropriate responses.
- Refactored `dispatch_triggered_workflows` to improve workflow execution logic and error handling.

These changes improve the robustness and clarity of the trigger management system.

api/core/plugin/entities/request.py

@@ -247,6 +247,7 @@ class Event(BaseModel):
 
 class TriggerInvokeResponse(BaseModel):
     event: Event
+    cancelled: Optional[bool] = False
 
 
 class PluginTriggerDispatchResponse(BaseModel):

api/core/trigger/entities/api_entities.py

@@ -49,7 +49,7 @@ class TriggerProviderApiEntity(BaseModel):
 
     supported_creation_methods: list[TriggerCreationMethod] = Field(
         default_factory=list,
-        description="Supported creation methods for the trigger provider. Possible values: 'OAUTH', 'APIKEY', 'MANUAL'."
+        description="Supported creation methods for the trigger provider. like 'OAUTH', 'APIKEY', 'MANUAL'.",
     )
 
     credentials_schema: list[ProviderConfig] = Field(description="The credentials schema of the trigger provider")

api/core/trigger/entities/entities.py

@@ -269,11 +269,6 @@ class TriggerInputs(BaseModel):
     trigger_name: str
     subscription_id: str
 
-    @classmethod
-    def from_trigger_entity(cls, request_id: str, subscription_id: str, trigger: TriggerEntity) -> "TriggerInputs":
-        """Create from trigger entity (for production)."""
-        return cls(request_id=request_id, trigger_name=trigger.identity.name, subscription_id=subscription_id)
-
     def to_workflow_args(self) -> dict[str, Any]:
         """Convert to workflow arguments format."""
         return {"inputs": self.model_dump(), "files": []}
@@ -282,11 +277,13 @@ class TriggerInputs(BaseModel):
         """Convert to dict (alias for model_dump)."""
         return self.model_dump()
 
+
 class TriggerCreationMethod(StrEnum):
     OAUTH = "OAUTH"
     APIKEY = "APIKEY"
     MANUAL = "MANUAL"
 
+
 # Export all entities
 __all__ = [
     "OAuthSchema",

api/core/trigger/errors.py

@@ -1,2 +1,8 @@
 class TriggerProviderCredentialValidationError(ValueError):
     pass
+
+class TriggerInvokeError(Exception):
+    pass
+
+class TriggerIgnoreEventError(TriggerInvokeError):
+    pass

api/core/trigger/trigger_manager.py

@@ -12,7 +12,8 @@ from flask import Request
 import contexts
 from core.plugin.entities.plugin import TriggerProviderID
 from core.plugin.entities.plugin_daemon import CredentialType
-from core.plugin.entities.request import TriggerInvokeResponse
+from core.plugin.entities.request import Event, TriggerInvokeResponse
+from core.plugin.impl.exc import PluginInvokeError
 from core.plugin.impl.trigger import PluginTriggerManager
 from core.trigger.entities.entities import (
     Subscription,
@@ -168,7 +169,14 @@ class TriggerManager:
         trigger = provider.get_trigger(trigger_name)
         if not trigger:
             raise ValueError(f"Trigger {trigger_name} not found in provider {provider_id}")
-        return provider.invoke_trigger(user_id, trigger_name, parameters, credentials, credential_type, request)
+        try:
+            return provider.invoke_trigger(user_id, trigger_name, parameters, credentials, credential_type, request)
+        except PluginInvokeError as e:
+            if e.get_error_type() == "TriggerIgnoreEventError":
+                return TriggerInvokeResponse(event=Event(variables={}), cancelled=True)
+            else:
+                logger.exception("Failed to invoke trigger")
+            raise
 
     @classmethod
     def subscribe_trigger(

api/core/workflow/nodes/trigger_plugin/trigger_plugin_node.py

@@ -1,18 +1,11 @@
 from collections.abc import Mapping
 from typing import Any, Optional
 
-from core.plugin.entities.plugin import TriggerProviderID
-from core.plugin.impl.exc import PluginDaemonClientSideError, PluginInvokeError
-from core.plugin.utils.http_parser import deserialize_request
-from core.trigger.entities.api_entities import TriggerProviderSubscriptionApiEntity
-from core.trigger.trigger_manager import TriggerManager
 from core.workflow.entities.node_entities import NodeRunResult
 from core.workflow.entities.workflow_node_execution import WorkflowNodeExecutionMetadataKey, WorkflowNodeExecutionStatus
 from core.workflow.nodes.base import BaseNode
 from core.workflow.nodes.base.entities import BaseNodeData, RetryConfig
 from core.workflow.nodes.enums import ErrorStrategy, NodeType
-from extensions.ext_storage import storage
-from services.trigger.trigger_provider_service import TriggerProviderService
 
 from .entities import PluginTriggerData
 
@@ -78,74 +71,9 @@ class TriggerPluginNode(BaseNode):
                 "plugin_unique_identifier": self._node_data.plugin_unique_identifier,
             },
         }
-
-        request_id = trigger_inputs.get("request_id")
-        trigger_name = trigger_inputs.get("trigger_name", "")
-        subscription_id = trigger_inputs.get("subscription_id", "")
-
-        if not request_id or not subscription_id:
-            return NodeRunResult(
-                status=WorkflowNodeExecutionStatus.FAILED,
-                inputs=trigger_inputs,
-                outputs={"error": "No request ID or subscription ID available"},
-            )
-        try:
-            subscription: TriggerProviderSubscriptionApiEntity | None = TriggerProviderService.get_subscription_by_id(
-                tenant_id=self.tenant_id, subscription_id=subscription_id
-            )
-            if not subscription:
-                return NodeRunResult(
-                    status=WorkflowNodeExecutionStatus.FAILED,
-                    inputs=trigger_inputs,
-                    outputs={"error": f"Invalid subscription {subscription_id} not found"},
-                )
-        except Exception as e:
-            return NodeRunResult(
-                status=WorkflowNodeExecutionStatus.FAILED,
-                inputs=trigger_inputs,
-                outputs={"error": f"Failed to get subscription: {str(e)}"},
-            )
-
-        try:
-            request = deserialize_request(storage.load_once(f"triggers/{request_id}"))
-            parameters = self._node_data.parameters if hasattr(self, "_node_data") and self._node_data else {}
-            invoke_response = TriggerManager.invoke_trigger(
-                tenant_id=self.tenant_id,
-                user_id=self.user_id,
-                provider_id=TriggerProviderID(subscription.provider),
-                trigger_name=trigger_name,
-                parameters=parameters,
-                credentials=subscription.credentials,
-                credential_type=subscription.credential_type,
-                request=request,
-            )
-            outputs = invoke_response.event.variables or {}
-            return NodeRunResult(status=WorkflowNodeExecutionStatus.SUCCEEDED, inputs=trigger_inputs, outputs=outputs)
-        except PluginInvokeError as e:
-            return NodeRunResult(
-                status=WorkflowNodeExecutionStatus.FAILED,
-                inputs=trigger_inputs,
-                metadata=metadata,
-                error="An error occurred in the plugin, "
-                f"please contact the author of {subscription.provider} for help, "
-                f"error type: {e.get_error_type()}, "
-                f"error details: {e.get_error_message()}",
-                error_type=type(e).__name__,
-            )
-        except PluginDaemonClientSideError as e:
-            return NodeRunResult(
-                status=WorkflowNodeExecutionStatus.FAILED,
-                inputs=trigger_inputs,
-                metadata=metadata,
-                error=f"Failed to invoke trigger, error: {e.description}",
-                error_type=type(e).__name__,
-            )
-
-        except Exception as e:
-            return NodeRunResult(
-                status=WorkflowNodeExecutionStatus.FAILED,
-                inputs=trigger_inputs,
-                metadata=metadata,
-                error=f"Failed to invoke trigger: {str(e)}",
-                error_type=type(e).__name__,
-            )
+        return NodeRunResult(
+            status=WorkflowNodeExecutionStatus.SUCCEEDED,
+            inputs=trigger_inputs,
+            outputs=trigger_inputs,
+            metadata=metadata,
+        )