youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-05 18:08:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: metadata batch edit silently fails due to split transactions and swallowed exceptions (#32041)

Browse Source
This commit is contained in:
Varun Chawla
2026-02-11 20:59:59 -08:00
committed by GitHub
parent 3fd1eea4d7
commit f233e2036f
5 changed files with 142 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api/services/metadata_service.py
View File

@ -220,8 +220,8 @@ class MetadataService:
doc_metadata[BuiltInField.source] = MetadataDataSource[document.data_source_type]
document.doc_metadata = doc_metadata
db.session.add(document)
db.session.commit()
# deal metadata binding
# deal metadata binding (in the same transaction as the doc_metadata update)
if not operation.partial_update:
db.session.query(DatasetMetadataBinding).filter_by(document_id=operation.document_id).delete()
@ -247,7 +247,9 @@ class MetadataService:
db.session.add(dataset_metadata_binding)
db.session.commit()
except Exception:
db.session.rollback()
logger.exception("Update documents metadata failed")
raise
finally:
redis_client.delete(lock_key)