feat: add property-based access control to GraphRuntimeState

- Replace direct field access with private attributes and property decorators
- Implement deep copy protection for mutable objects (dict, LLMUsage)
- Add helper methods: set_output(), get_output(), update_outputs()
- Add increment_node_run_steps() and add_tokens() convenience methods
- Update loop_node and event_handlers to use new accessor methods
- Add comprehensive unit tests for immutability and validation
- Ensure backward compatibility with existing property access patterns
This commit is contained in:
-LAN-
2025-09-04 02:08:58 +08:00
parent 9c96b23d55
commit fe3f03e50a
4 changed files with 250 additions and 24 deletions

View File

@ -0,0 +1,114 @@
from time import time
import pytest
from core.workflow.entities.graph_runtime_state import GraphRuntimeState
from core.workflow.entities.variable_pool import VariablePool
class TestGraphRuntimeState:
def test_property_getters_and_setters(self):
# FIXME(-LAN-): Mock VariablePool if needed
variable_pool = VariablePool()
start_time = time()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=start_time)
# Test variable_pool property
assert state.variable_pool == variable_pool
new_pool = VariablePool()
state.variable_pool = new_pool
assert state.variable_pool == new_pool
# Test start_at property
assert state.start_at == start_time
new_time = time() + 100
state.start_at = new_time
assert state.start_at == new_time
# Test total_tokens property
assert state.total_tokens == 0
state.total_tokens = 100
assert state.total_tokens == 100
# Test node_run_steps property
assert state.node_run_steps == 0
state.node_run_steps = 5
assert state.node_run_steps == 5
def test_outputs_immutability(self):
variable_pool = VariablePool()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=time())
# Test that getting outputs returns a copy
outputs1 = state.outputs
outputs2 = state.outputs
assert outputs1 == outputs2
assert outputs1 is not outputs2 # Different objects
# Test that modifying retrieved outputs doesn't affect internal state
outputs = state.outputs
outputs["test"] = "value"
assert "test" not in state.outputs
# Test set_output method
state.set_output("key1", "value1")
assert state.get_output("key1") == "value1"
# Test update_outputs method
state.update_outputs({"key2": "value2", "key3": "value3"})
assert state.get_output("key2") == "value2"
assert state.get_output("key3") == "value3"
def test_llm_usage_immutability(self):
variable_pool = VariablePool()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=time())
# Test that getting llm_usage returns a copy
usage1 = state.llm_usage
usage2 = state.llm_usage
assert usage1 is not usage2 # Different objects
def test_type_validation(self):
variable_pool = VariablePool()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=time())
# Test total_tokens validation
with pytest.raises(ValueError):
state.total_tokens = -1
# Test node_run_steps validation
with pytest.raises(ValueError):
state.node_run_steps = -1
def test_helper_methods(self):
variable_pool = VariablePool()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=time())
# Test increment_node_run_steps
initial_steps = state.node_run_steps
state.increment_node_run_steps()
assert state.node_run_steps == initial_steps + 1
# Test add_tokens
initial_tokens = state.total_tokens
state.add_tokens(50)
assert state.total_tokens == initial_tokens + 50
# Test add_tokens validation
with pytest.raises(ValueError):
state.add_tokens(-1)
def test_deep_copy_for_nested_objects(self):
variable_pool = VariablePool()
state = GraphRuntimeState(variable_pool=variable_pool, start_at=time())
# Test deep copy for nested dict
nested_data = {"level1": {"level2": {"value": "test"}}}
state.set_output("nested", nested_data)
retrieved = state.get_output("nested")
retrieved["level1"]["level2"]["value"] = "modified"
# Original should remain unchanged
assert state.get_output("nested")["level1"]["level2"]["value"] == "test"