Files
dify/api/tests/unit_tests/controllers/openapi/test_device_token.py
GareArc 2a38df2b7f refactor(api): consolidate openapi/oauth_device into per-domain modules
Match the existing api-group convention: one module per resource family
with multiple Resource classes per file (cf service_api/dataset/dataset.py
with 7 routes, console/auth/oauth_device.py with 2 before this branch).

The Phase B-D fragmentation (one file per route under
controllers/openapi/oauth_device/) was inconsistent with the codebase.
Collapse into:

  controllers/openapi/oauth_device.py        (5 routes: code, token,
                                              lookup, approve, deny —
                                              account branch)
  controllers/openapi/oauth_device_sso.py    (4 routes: sso-initiate,
                                              sso-complete,
                                              approval-context,
                                              approve-external —
                                              EE-only SSO branch)

The split mirrors the original pre-migration layout: account branch in
console/auth/oauth_device.py, SSO branch in controllers/oauth_device_sso.py
(root). Both legacy mount files updated to import from the new modules.

No behavior change; 59 tests still green. Test files updated to import
from the consolidated module paths.

Plan: docs/superpowers/plans/2026-04-26-openapi-migration.md (in difyctl repo).
2026-04-27 00:07:15 -07:00

47 lines
1.5 KiB
Python

"""Phase B step 7: POST /openapi/v1/oauth/device/token mounted via the
canonical class. Legacy /v1/oauth/device/token re-registered. Both
paths must dispatch to the same class.
"""
import builtins
import pytest
from flask import Flask
from flask.views import MethodView
from controllers.openapi import bp as openapi_bp
from controllers.openapi.oauth_device import OAuthDeviceTokenApi
from controllers.service_api import bp as service_api_bp
if not hasattr(builtins, "MethodView"):
builtins.MethodView = MethodView # type: ignore[attr-defined]
@pytest.fixture
def dual_app() -> Flask:
app = Flask(__name__)
app.config["TESTING"] = True
app.register_blueprint(service_api_bp)
app.register_blueprint(openapi_bp)
return app
def test_openapi_route_registered(dual_app: Flask):
rules = {r.rule for r in dual_app.url_map.iter_rules()}
assert "/openapi/v1/oauth/device/token" in rules
def test_legacy_v1_route_registered(dual_app: Flask):
rules = {r.rule for r in dual_app.url_map.iter_rules()}
assert "/v1/oauth/device/token" in rules
def test_both_paths_dispatch_to_same_class(dual_app: Flask):
new = next(
r for r in dual_app.url_map.iter_rules() if r.rule == "/openapi/v1/oauth/device/token"
)
legacy = next(
r for r in dual_app.url_map.iter_rules() if r.rule == "/v1/oauth/device/token"
)
assert dual_app.view_functions[new.endpoint].view_class is OAuthDeviceTokenApi
assert dual_app.view_functions[legacy.endpoint].view_class is OAuthDeviceTokenApi