mirror of
https://github.com/langgenius/dify.git
synced 2026-04-26 13:45:57 +08:00
49befa6d3f
Added support for an optional `download_filename` parameter in the `get_download_url` and `get_download_urls` methods across various storage classes. This allows users to specify a custom filename for downloads, improving user experience by enabling better file naming during downloads. Updated related methods and tests to accommodate this new functionality.
74 lines
3.1 KiB
Python
74 lines
3.1 KiB
Python
"""Storage wrapper that provides presigned URL support with fallback to ticket-based URLs.
|
|
|
|
This is the unified presign wrapper for all storage operations. When the underlying
|
|
storage backend doesn't support presigned URLs (raises NotImplementedError), it falls
|
|
back to generating ticket-based URLs that route through Dify's file proxy endpoints.
|
|
|
|
Usage:
|
|
from extensions.storage.file_presign_storage import FilePresignStorage
|
|
|
|
# Wrap any BaseStorage to add presign support
|
|
presign_storage = FilePresignStorage(base_storage)
|
|
download_url = presign_storage.get_download_url("path/to/file.txt", expires_in=3600)
|
|
upload_url = presign_storage.get_upload_url("path/to/file.txt", expires_in=3600)
|
|
|
|
When the underlying storage doesn't support presigned URLs, the fallback URLs follow the format:
|
|
{FILES_URL}/files/storage-tickets/{token}
|
|
|
|
The token is a UUID that maps to the real storage key in Redis.
|
|
"""
|
|
|
|
from extensions.storage.storage_wrapper import StorageWrapper
|
|
|
|
|
|
class FilePresignStorage(StorageWrapper):
|
|
"""Storage wrapper that provides presigned URL support with ticket fallback.
|
|
|
|
If the wrapped storage supports presigned URLs, delegates to it.
|
|
Otherwise, generates ticket-based URLs for both download and upload operations.
|
|
"""
|
|
|
|
def get_download_url(
|
|
self,
|
|
filename: str,
|
|
expires_in: int = 3600,
|
|
*,
|
|
download_filename: str | None = None,
|
|
) -> str:
|
|
"""Get a presigned download URL, falling back to ticket URL if not supported."""
|
|
try:
|
|
return self._storage.get_download_url(filename, expires_in, download_filename=download_filename)
|
|
except NotImplementedError:
|
|
from services.storage_ticket_service import StorageTicketService
|
|
|
|
return StorageTicketService.create_download_url(filename, expires_in=expires_in, filename=download_filename)
|
|
|
|
def get_download_urls(
|
|
self,
|
|
filenames: list[str],
|
|
expires_in: int = 3600,
|
|
*,
|
|
download_filenames: list[str] | None = None,
|
|
) -> list[str]:
|
|
"""Get presigned download URLs for multiple files."""
|
|
try:
|
|
return self._storage.get_download_urls(filenames, expires_in, download_filenames=download_filenames)
|
|
except NotImplementedError:
|
|
from services.storage_ticket_service import StorageTicketService
|
|
|
|
if download_filenames is None:
|
|
return [StorageTicketService.create_download_url(f, expires_in=expires_in) for f in filenames]
|
|
return [
|
|
StorageTicketService.create_download_url(f, expires_in=expires_in, filename=df)
|
|
for f, df in zip(filenames, download_filenames, strict=True)
|
|
]
|
|
|
|
def get_upload_url(self, filename: str, expires_in: int = 3600) -> str:
|
|
"""Get a presigned upload URL, falling back to ticket URL if not supported."""
|
|
try:
|
|
return self._storage.get_upload_url(filename, expires_in)
|
|
except NotImplementedError:
|
|
from services.storage_ticket_service import StorageTicketService
|
|
|
|
return StorageTicketService.create_upload_url(filename, expires_in=expires_in)
|