diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ea712e5..8fc0fc9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -98,19 +98,6 @@ jobs: /bin/sh -c "./configure ${CONFIGURE_OPTIONS}" make --jobs=$(nproc) - - name: Cppcheck - run: | - # specify the version range to run cppcheck (cppcheck version number is x.y or x.y.z) - if cppcheck --version | sed -e 's/\./ /g' | awk '{if (($2 * 1000 + $3) <= 2004) { exit(1) } }'; then - make cppcheck - fi - - - name: Shellcheck - run: | - if shellcheck --version | awk -F '[ .]' '/version:/ && ($2 * 1000 + $3 <= 7) { exit(1) }'; then - make shellcheck - fi - - name: Test suite run: | make check -C src @@ -276,7 +263,7 @@ jobs: run: | /bin/sh -c "ALL_TESTS=1 ASAN_OPTIONS=${ASAN_OPTIONS} TSAN_OPTIONS=${TSAN_OPTIONS} VALGRIND=${VALGRIND} RETRIES=${RETRIES} make check -C test || (test/filter-suite-log.sh test/test-suite.log; exit 1)" - clang-tidy: + static-checks: runs-on: ubuntu-latest container: image: fedora:41 @@ -299,6 +286,13 @@ jobs: run: | make clang-tidy + - name: Cppcheck + run: | + make cppcheck + + - name: Shellcheck + run: | + make shellcheck # # Local variables: diff --git a/.github/workflows/linux-ci-helper.sh b/.github/workflows/linux-ci-helper.sh index b64a8fa..f2e6a9c 100755 --- a/.github/workflows/linux-ci-helper.sh +++ b/.github/workflows/linux-ci-helper.sh @@ -79,7 +79,6 @@ CONFIGURE_OPTIONS="--prefix=/usr --with-openssl" # PACKAGE_ENABLE_REPO_OPTIONS="" PACKAGE_INSTALL_ADDITIONAL_OPTIONS="" -SHELLCHECK_DIRECT_INSTALL=0 AWSCLI_DIRECT_INSTALL=1 if [ "${CONTAINER_FULLNAME}" = "ubuntu:24.10" ]; then @@ -87,27 +86,21 @@ if [ "${CONTAINER_FULLNAME}" = "ubuntu:24.10" ]; then PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="autoconf autotools-dev clang-tidy openjdk-21-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mailcap libtool pkg-config libssl-dev attr curl python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="autoconf autotools-dev openjdk-21-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mailcap libtool pkg-config libssl-dev attr curl python3-pip unzip" elif [ "${CONTAINER_FULLNAME}" = "ubuntu:24.04" ]; then PACKAGE_MANAGER_BIN="apt-get" PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="autoconf autotools-dev clang-tidy openjdk-21-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mailcap libtool pkg-config libssl-dev attr curl python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="autoconf autotools-dev openjdk-21-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mailcap libtool pkg-config libssl-dev attr curl python3-pip unzip" elif [ "${CONTAINER_FULLNAME}" = "ubuntu:22.04" ]; then PACKAGE_MANAGER_BIN="apt-get" PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="autoconf autotools-dev clang-tidy openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="autoconf autotools-dev openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl python3-pip unzip" elif [ "${CONTAINER_FULLNAME}" = "ubuntu:20.04" ]; then PACKAGE_MANAGER_BIN="apt-get" @@ -115,17 +108,13 @@ elif [ "${CONTAINER_FULLNAME}" = "ubuntu:20.04" ]; then PACKAGE_INSTALL_OPTIONS="install -y" INSTALL_PACKAGES="autoconf autotools-dev openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" elif [ "${CONTAINER_FULLNAME}" = "debian:bookworm" ]; then PACKAGE_MANAGER_BIN="apt-get" PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="autoconf autotools-dev clang-tidy openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl procps python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="autoconf autotools-dev openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl procps python3-pip unzip" elif [ "${CONTAINER_FULLNAME}" = "debian:bullseye" ]; then PACKAGE_MANAGER_BIN="apt-get" @@ -133,8 +122,6 @@ elif [ "${CONTAINER_FULLNAME}" = "debian:bullseye" ]; then PACKAGE_INSTALL_OPTIONS="install -y" INSTALL_PACKAGES="autoconf autotools-dev openjdk-17-jre-headless fuse jq libfuse-dev libcurl4-openssl-dev libxml2-dev locales-all mime-support libtool pkg-config libssl-dev attr curl procps python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" elif [ "${CONTAINER_FULLNAME}" = "rockylinux:9" ]; then PACKAGE_MANAGER_BIN="dnf" @@ -149,13 +136,6 @@ elif [ "${CONTAINER_FULLNAME}" = "rockylinux:9" ]; then PACKAGE_INSTALL_ADDITIONAL_OPTIONS="--allowerasing" INSTALL_PACKAGES="clang-tools-extra curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-17-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel attr diffutils curl python3 procps unzip xz https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm" - INSTALL_CHECKER_PKGS="cppcheck" - INSTALL_CHECKER_PKG_OPTIONS="--enablerepo=epel" - - # [NOTE] - # For RockyLinux, ShellCheck is downloaded from the github archive and installed. - # - SHELLCHECK_DIRECT_INSTALL=1 elif [ "${CONTAINER_FULLNAME}" = "rockylinux:8" ]; then PACKAGE_MANAGER_BIN="dnf" @@ -163,40 +143,27 @@ elif [ "${CONTAINER_FULLNAME}" = "rockylinux:8" ]; then PACKAGE_INSTALL_OPTIONS="install -y" INSTALL_PACKAGES="clang-tools-extra curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-17-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel attr diffutils curl python3 unzip" - INSTALL_CHECKER_PKGS="cppcheck" - INSTALL_CHECKER_PKG_OPTIONS="--enablerepo=powertools" - - # [NOTE] - # For RockyLinux, ShellCheck is downloaded from the github archive and installed. - # - SHELLCHECK_DIRECT_INSTALL=1 elif [ "${CONTAINER_FULLNAME}" = "fedora:41" ]; then PACKAGE_MANAGER_BIN="dnf" PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="clang clang-tools-extra curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-latest-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel curl attr diffutils procps python3-pip unzip libcxx libcxx-devel" - INSTALL_CHECKER_PKGS="cppcheck ShellCheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="clang clang-tools-extra cppcheck curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-latest-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel curl attr diffutils procps python3-pip unzip libcxx libcxx-devel ShellCheck" elif [ "${CONTAINER_FULLNAME}" = "fedora:40" ]; then PACKAGE_MANAGER_BIN="dnf" PACKAGE_UPDATE_OPTIONS="update -y -qq" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="clang-tools-extra curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-latest-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel curl attr diffutils procps python3-pip unzip" - INSTALL_CHECKER_PKGS="cppcheck ShellCheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="clang clang-tools-extra cppcheck curl-devel fuse fuse-devel gcc libstdc++-devel gcc-c++ glibc-langpack-en java-latest-openjdk-headless jq libxml2-devel mailcap git automake make openssl openssl-devel curl attr diffutils procps python3-pip unzip libcxx libcxx-devel ShellCheck" elif [ "${CONTAINER_FULLNAME}" = "opensuse/leap:15" ]; then PACKAGE_MANAGER_BIN="zypper" PACKAGE_UPDATE_OPTIONS="refresh" PACKAGE_INSTALL_OPTIONS="install -y" - INSTALL_PACKAGES="automake clang-tools curl-devel fuse fuse-devel gcc-c++ java-17-openjdk-headless jq libxml2-devel make openssl openssl-devel python3-pip curl attr ShellCheck procps unzip" - INSTALL_CHECKER_PKGS="cppcheck ShellCheck" - INSTALL_CHECKER_PKG_OPTIONS="" + INSTALL_PACKAGES="automake clang-tools curl-devel fuse fuse-devel gcc-c++ java-17-openjdk-headless jq libxml2-devel make openssl openssl-devel python3-pip curl attr procps unzip" elif [ "${CONTAINER_FULLNAME}" = "alpine:3.21" ]; then PACKAGE_MANAGER_BIN="apk" @@ -204,8 +171,6 @@ elif [ "${CONTAINER_FULLNAME}" = "alpine:3.21" ]; then PACKAGE_INSTALL_OPTIONS="add --no-progress --no-cache" INSTALL_PACKAGES="bash clang-extra-tools curl g++ make automake autoconf libtool git curl-dev fuse-dev jq libxml2-dev openssl coreutils procps attr sed mailcap openjdk17 aws-cli" - INSTALL_CHECKER_PKGS="cppcheck shellcheck" - INSTALL_CHECKER_PKG_OPTIONS="" AWSCLI_DIRECT_INSTALL=0 @@ -224,36 +189,11 @@ echo "${PRGNAME} [INFO] Updates." /bin/sh -c "${PACKAGE_MANAGER_BIN} ${PACKAGE_UPDATE_OPTIONS}" # -# Install packages ( with cppcheck ) +# Install packages # echo "${PRGNAME} [INFO] Install packages." /bin/sh -c "${PACKAGE_MANAGER_BIN} ${PACKAGE_ENABLE_REPO_OPTIONS} ${PACKAGE_INSTALL_OPTIONS} ${PACKAGE_INSTALL_ADDITIONAL_OPTIONS} ${INSTALL_PACKAGES}" -echo "${PRGNAME} [INFO] Install cppcheck package." -/bin/sh -c "${PACKAGE_MANAGER_BIN} ${INSTALL_CHECKER_PKG_OPTIONS} ${PACKAGE_INSTALL_OPTIONS} ${INSTALL_CHECKER_PKGS}" - -# -# Install ShellCheck manually -# -if [ "${SHELLCHECK_DIRECT_INSTALL}" -eq 1 ]; then - echo "${PRGNAME} [INFO] Install shellcheck package from github archive." - - if ! LATEST_SHELLCHECK_DOWNLOAD_URL=$(curl --silent --show-error https://api.github.com/repos/koalaman/shellcheck/releases/latest | jq -r '.assets[].browser_download_url | select(contains("linux.x86_64"))'); then - echo "Could not get shellcheck package url" - exit 1 - fi - if ! curl -s -S -L -o /tmp/shellcheck.tar.xz "${LATEST_SHELLCHECK_DOWNLOAD_URL}"; then - echo "Failed to download shellcheck package from ${LATEST_SHELLCHECK_DOWNLOAD_URL}" - exit 1 - fi - if ! tar -C /usr/bin/ -xf /tmp/shellcheck.tar.xz --no-anchored 'shellcheck' --strip=1; then - echo "Failed to extract and install shellcheck." - rm -f /tmp/shellcheck.tar.xz - exit 1 - fi - rm -f /tmp/shellcheck.tar.xz -fi - # Check Java version java -version