From 8948eded09500f9c9b7a12781e69ba5e98e52faf Mon Sep 17 00:00:00 2001
From: Andrew Gaul <andrew@gaul.org>
Date: Wed, 30 Jun 2021 08:42:44 +0900
Subject: [PATCH] Address clang-tidy warnings (#1703)

---
 src/fdcache_entity.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/fdcache_entity.cpp b/src/fdcache_entity.cpp
index 104edb9..c1b9f61 100644
--- a/src/fdcache_entity.cpp
+++ b/src/fdcache_entity.cpp
@@ -142,9 +142,7 @@ void FdEntity::Clear()
 
     for(fdinfo_map_t::iterator iter = pseudo_fd_map.begin(); iter != pseudo_fd_map.end(); ++iter){
         PseudoFdInfo* ppseudofdinfo = iter->second;
-        if(ppseudofdinfo){
-            delete ppseudofdinfo;
-        }
+        delete ppseudofdinfo;
     }
     pseudo_fd_map.clear();
 
@@ -1261,7 +1259,7 @@ int FdEntity::NoCacheMultipartPost(PseudoFdInfo* pseudo_obj, int tgfd, off_t sta
     }
 
     // get upload id
-    std::string upload_id("");
+    std::string upload_id;
     if(!pseudo_obj->GetUploadId(upload_id)){
         return -EIO;
     }
@@ -1290,7 +1288,7 @@ int FdEntity::NoCacheCompleteMultipartPost(PseudoFdInfo* pseudo_obj)
     }
 
     // get upload id
-    std::string upload_id("");
+    std::string upload_id;
     if(!pseudo_obj->GetUploadId(upload_id)){
         return -EIO;
     }