youngkingdom/s3fs-fuse
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed unnecessary conversion to in DirStatCache::TruncateCacheHasLock (#2706)

Browse Source
This commit is contained in:
Takeshi Nakatani
2025-08-22 19:57:36 +09:00
committed by GitHub
parent 066a2f8fa6
commit ecdcb4a836
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cache_node.cpp
View File

@ -1176,6 +1176,8 @@ bool DirStatCache::IsExpiredHasLock()
bool DirStatCache::TruncateCacheHasLock() bool DirStatCache::TruncateCacheHasLock()
{ {
bool isTruncated = false;
// check self // check self
if(StatCacheNode::IsExpiredHasLock()){ if(StatCacheNode::IsExpiredHasLock()){
// [NOTE] // [NOTE]
@ -1186,22 +1188,20 @@ bool DirStatCache::TruncateCacheHasLock()
return false; return false;
} }
} }
bool isTruncated = false;
// Check all children // Check all children
std::lock_guard<std::mutex> dircachelock(dir_cache_lock); std::lock_guard<std::mutex> dircachelock(dir_cache_lock);
for(auto iter = children.begin(); iter != children.end(); ){ for(auto iter = children.begin(); iter != children.end(); ){
std::shared_ptr<DirStatCache> pDirCache = ConvertStatCacheObject<DirStatCache>(iter->second); if(iter->second->isDirectoryHasLock()){
if(pDirCache){
// [NOTE] // [NOTE]
// It is checked only if the expire time has passed since the last check. // It is checked only if the expire time has passed since the last check.
// //
if(pDirCache->NeedTruncateProcessing()){ if(iter->second->IsExpireStatCacheTimeHasLock()){
if(pDirCache->TruncateCacheHasLock()){ if(iter->second->TruncateCacheHasLock()){
// Some files and directories under the directory have been deleted. // Some files and directories under the directory have been deleted.
isTruncated = true; isTruncated = true;
if(pDirCache->IsExpiredHasLock()){ if(iter->second->IsExpiredHasLock()){
// This child directory is now empty and can be deleted. // This child directory is now empty and can be deleted.
S3FS_PRN_DBG("Remove stat cache [directory path=%s]", iter->first.c_str()); S3FS_PRN_DBG("Remove stat cache [directory path=%s]", iter->first.c_str());