Add downscale ratio to empty ltxv latent. (#13999)

Aligns the OSS spec with the cloud-side BE-1004 contract:

- createWorkspaceApiKey request body: add maxLength: 5000 to the
  description property (matches cloud's hub_profile.description
  MaxLen(5000) convention; enforced cloud-side via handler check).
- WorkspaceApiKey + WorkspaceApiKeyCreated response schemas:
  mark description as required (cloud's handler always populates
  the field, defaulting to empty string when not supplied on create),
  drop nullable: true, add maxLength: 5000 for symmetry, and clarify
  the doc string ("Always present in responses; empty string when no
  description was supplied on create").

Both schemas are tagged x-runtime: [cloud] at the schema level so the
tightening is correctly scoped — OSS-only implementations are not
required to honor the workspace API keys endpoints at all.

Related cloud PR: Comfy-Org/cloud#3747

app/assets/scanner.py

@@ -33,7 +33,6 @@ from app.assets.services.file_utils import (
     verify_file_unchanged,
 )
 from app.assets.services.hashing import HashCheckpoint, compute_blake3_hash
-from app.assets.services.image_dimensions import extract_image_dimensions
 from app.assets.services.metadata_extract import extract_file_metadata
 from app.assets.services.path_utils import (
     compute_relative_filename,
@@ -507,10 +506,6 @@ def enrich_asset(
 
     if extract_metadata and metadata:
         system_metadata = metadata.to_user_metadata()
-        if mime_type and mime_type.startswith("image/"):
-            dims = extract_image_dimensions(file_path, mime_type=mime_type)
-            if dims:
-                system_metadata.update(dims)
         set_reference_system_metadata(session, reference_id, system_metadata)
 
     if full_hash:

app/assets/services/image_dimensions.py

@@ -1,63 +0,0 @@
-"""Image dimension extraction for asset ingest.
-
-Reads only the image header via Pillow to capture width/height cheaply,
-without a full pixel decode. Returns a metadata dict suitable for merging
-into ``AssetReference.system_metadata``.
-"""
-from __future__ import annotations
-
-import logging
-from typing import Any
-
-logger = logging.getLogger(__name__)
-
-
-def extract_image_dimensions(
-    file_path: str, mime_type: str | None = None
-) -> dict[str, Any] | None:
-    """Extract image dimensions for the file at ``file_path``.
-
-    Args:
-        file_path: Absolute path to a file on disk.
-        mime_type: Optional MIME type hint. When provided and not prefixed
-            with ``image/``, extraction is skipped without touching the file.
-
-    Returns:
-        ``{"kind": "image", "width": W, "height": H}`` when the file is a
-        recognizable image with positive dimensions, otherwise ``None``.
-
-    The dict shape is intended to be merged into ``system_metadata`` so the
-    asset response surfaces ``metadata.kind`` plus dimension fields for image
-    assets. Forward-compatible: future media kinds (e.g. ``"video"`` with
-    duration/fps) can extend this shape without schema changes.
-    """
-    if mime_type is not None and not mime_type.startswith("image/"):
-        return None
-
-    try:
-        from PIL import Image, UnidentifiedImageError
-    except ImportError:
-        logger.debug(
-            "Pillow not available; skipping image dimension extraction for %s",
-            file_path,
-        )
-        return None
-
-    try:
-        with Image.open(file_path) as img:
-            width, height = img.size
-    except (OSError, UnidentifiedImageError, ValueError) as exc:
-        logger.debug(
-            "Failed to read image dimensions from %s: %s", file_path, exc
-        )
-        return None
-
-    if (
-        not isinstance(width, int)
-        or not isinstance(height, int)
-        or width <= 0
-        or height <= 0
-    ):
-        return None
-
-    return {"kind": "image", "width": width, "height": height}

app/assets/services/ingest.py

@@ -17,11 +17,9 @@ from app.assets.database.queries import (
     get_reference_by_file_path,
     get_reference_tags,
     get_or_create_reference,
-    list_references_by_asset_id,
     reference_exists,
     remove_missing_tag_for_asset_id,
     set_reference_metadata,
-    set_reference_system_metadata,
     set_reference_tags,
     update_asset_hash_and_mime,
     upsert_asset,
@@ -31,7 +29,6 @@ from app.assets.database.queries import (
 from app.assets.helpers import get_utc_now, normalize_tags
 from app.assets.services.bulk_ingest import batch_insert_seed_assets
 from app.assets.services.file_utils import get_size_and_mtime_ns
-from app.assets.services.image_dimensions import extract_image_dimensions
 from app.assets.services.path_utils import (
     compute_relative_filename,
     get_name_and_tags_from_asset_path,
@@ -121,14 +118,6 @@ def _ingest_file_from_path(
                 user_metadata=user_metadata,
             )
 
-            _maybe_store_image_dimensions(
-                session,
-                reference_id=reference_id,
-                file_path=locator,
-                mime_type=mime_type,
-                current_system_metadata=ref.system_metadata,
-            )
-
         try:
             remove_missing_tag_for_asset_id(session, asset_id=asset.id)
         except Exception:
@@ -299,13 +288,6 @@ def _register_existing_asset(
                 user_metadata=new_meta,
             )
 
-        _backfill_image_dimensions_from_siblings(
-            session,
-            asset_id=asset.id,
-            new_reference_id=ref.id,
-            current_system_metadata=ref.system_metadata,
-        )
-
         if tags is not None:
             set_reference_tags(
                 session,
@@ -352,87 +334,6 @@ def _update_metadata_with_filename(
         )
 
 
-_IMAGE_DIMENSION_KEYS = ("kind", "width", "height")
-
-
-def _maybe_store_image_dimensions(
-    session: Session,
-    reference_id: str,
-    file_path: str,
-    mime_type: str | None,
-    current_system_metadata: dict | None,
-) -> None:
-    """Populate ``kind``/``width``/``height`` on system_metadata for image refs.
-
-    Non-image MIME types are a no-op. Pre-existing keys (e.g. enricher-written
-    safetensors metadata, download provenance) are preserved by merge.
-    """
-    if not mime_type or not mime_type.startswith("image/"):
-        return
-
-    dims = extract_image_dimensions(file_path, mime_type=mime_type)
-    if not dims:
-        return
-
-    current = current_system_metadata or {}
-    merged = dict(current)
-    merged.update(dims)
-    if merged != current:
-        set_reference_system_metadata(
-            session,
-            reference_id=reference_id,
-            system_metadata=merged,
-        )
-
-
-def _backfill_image_dimensions_from_siblings(
-    session: Session,
-    asset_id: str,
-    new_reference_id: str,
-    current_system_metadata: dict | None,
-) -> None:
-    """Copy image dimension keys from any sibling reference of the same asset.
-
-    The from-hash path doesn't read the file bytes, so dimensions can't be
-    extracted there directly. When another reference of the same asset already
-    carries image dimensions, copy them onto the new reference so consumers
-    see consistent metadata regardless of how the asset was registered.
-
-    Best-effort: missing siblings, non-image siblings, or absent dimension
-    keys leave the target reference unchanged.
-    """
-    current = current_system_metadata or {}
-    if current.get("kind") == "image" and "width" in current and "height" in current:
-        return
-
-    for sibling in list_references_by_asset_id(session, asset_id):
-        if sibling.id == new_reference_id:
-            continue
-        meta = sibling.system_metadata or {}
-        if meta.get("kind") != "image":
-            continue
-        width = meta.get("width")
-        height = meta.get("height")
-        if (
-            type(width) is not int
-            or type(height) is not int
-            or width <= 0
-            or height <= 0
-        ):
-            continue
-        merged = dict(current)
-        merged["kind"] = "image"
-        merged["width"] = width
-        merged["height"] = height
-        if merged != current:
-            set_reference_system_metadata(
-                session,
-                reference_id=new_reference_id,
-                system_metadata=merged,
-            )
-        return
-
-
 def _sanitize_filename(name: str | None, fallback: str) -> str:
     n = os.path.basename((name or "").strip() or fallback)
     return n if n else fallback

comfy_extras/nodes_lt.py

@@ -77,7 +77,7 @@ class EmptyLTXVLatentVideo(io.ComfyNode):
     @classmethod
     def execute(cls, width, height, length, batch_size=1) -> io.NodeOutput:
         latent = torch.zeros([batch_size, 128, ((length - 1) // 8) + 1, height // 32, width // 32], device=comfy.model_management.intermediate_device())
-        return io.NodeOutput({"samples": latent})
+        return io.NodeOutput({"samples": latent, "downscale_ratio_spacial": 32})
 
     generate = execute  # TODO: remove
 

comfy_extras/nodes_string.py

@@ -1,10 +1,41 @@
 import re
 import json
+import string
 from typing_extensions import override
 
 from comfy_api.latest import ComfyExtension, io
 
 
+class StringFormat(io.ComfyNode):
+    @classmethod
+    def define_schema(cls) -> io.Schema:
+        autogrow = io.Autogrow.TemplateNames(
+            input=io.AnyType.Input("value"),
+            names=list(string.ascii_lowercase),
+            min=0,
+        )
+        return io.Schema(
+            node_id="StringFormat",
+            display_name="Format Text",
+            category="text",
+            search_aliases=["string", "format"],
+            description="Same as Python's string format method. Supports all of Python's format options and features.",
+            inputs=[
+                io.Autogrow.Input("values", template=autogrow),
+                io.String.Input("f_string", default="{a}", multiline=True),
+            ],
+            outputs=[
+                io.String.Output(),
+            ],
+        )
+
+    @classmethod
+    def execute(
+        cls, values: io.Autogrow.Type, f_string: str
+    ) -> io.NodeOutput:
+        return io.NodeOutput(f_string.format(**values))
+
+
 class StringConcatenate(io.ComfyNode):
     @classmethod
     def define_schema(cls):
@@ -413,6 +444,7 @@ class StringExtension(ComfyExtension):
     @override
     async def get_node_list(self) -> list[type[io.ComfyNode]]:
         return [
+            StringFormat,
             StringConcatenate,
             StringSubstring,
             StringLength,

openapi.yaml

@@ -4162,7 +4162,8 @@ paths:
                   description: Display name for the API key
                 description:
                   type: string
-                  description: User-provided description for the key
+                  description: User-provided description of the key's purpose
+                  maxLength: 5000
       responses:
         "201":
           description: API key created
@@ -7680,6 +7681,7 @@ components:
       required:
         - id
         - name
+        - description
       properties:
         id:
           type: string
@@ -7687,8 +7689,8 @@ components:
           type: string
         description:
           type: string
-          nullable: true
-          description: User-provided description
+          maxLength: 5000
+          description: User-provided description of the key's purpose. Always present in responses; empty string when no description was supplied on create.
         prefix:
           type: string
           description: First few characters of the key for identification
@@ -7709,6 +7711,7 @@ components:
       required:
         - id
         - name
+        - description
         - key
       properties:
         id:
@@ -7717,8 +7720,8 @@ components:
           type: string
         description:
           type: string
-          nullable: true
-          description: User-provided description
+          maxLength: 5000
+          description: User-provided description of the key's purpose. Always present in responses; empty string when no description was supplied on create.
         key:
           type: string
           description: Full API key value (only returned on creation)

tests-unit/assets_test/services/test_image_dimensions.py

@@ -1,86 +0,0 @@
-"""Tests for the image_dimensions service."""
-from __future__ import annotations
-
-from pathlib import Path
-
-import pytest
-from PIL import Image
-
-from app.assets.services.image_dimensions import extract_image_dimensions
-
-
-def _make_png(path: Path, size: tuple[int, int]) -> Path:
-    img = Image.new("RGB", size, color=(123, 45, 67))
-    img.save(path, format="PNG")
-    return path
-
-
-def _make_jpeg(path: Path, size: tuple[int, int]) -> Path:
-    img = Image.new("RGB", size, color=(10, 20, 30))
-    img.save(path, format="JPEG", quality=80)
-    return path
-
-
-class TestExtractImageDimensions:
-    def test_extracts_png_dimensions(self, tmp_path: Path):
-        f = _make_png(tmp_path / "rect.png", (320, 240))
-
-        result = extract_image_dimensions(str(f), mime_type="image/png")
-
-        assert result == {"kind": "image", "width": 320, "height": 240}
-
-    def test_extracts_jpeg_dimensions(self, tmp_path: Path):
-        f = _make_jpeg(tmp_path / "shot.jpg", (1920, 1080))
-
-        result = extract_image_dimensions(str(f), mime_type="image/jpeg")
-
-        assert result == {"kind": "image", "width": 1920, "height": 1080}
-
-    def test_works_when_mime_type_is_none(self, tmp_path: Path):
-        f = _make_png(tmp_path / "no_mime.png", (50, 100))
-
-        result = extract_image_dimensions(str(f), mime_type=None)
-
-        assert result == {"kind": "image", "width": 50, "height": 100}
-
-    def test_skips_non_image_mime_without_touching_file(self, tmp_path: Path):
-        # Path doesn't need to exist — non-image MIME short-circuits.
-        result = extract_image_dimensions(
-            str(tmp_path / "model.safetensors"),
-            mime_type="application/octet-stream",
-        )
-
-        assert result is None
-
-    @pytest.mark.parametrize(
-        "mime",
-        ["application/json", "text/plain", "video/mp4", "audio/mpeg"],
-    )
-    def test_skips_all_non_image_mime_types(self, tmp_path: Path, mime: str):
-        f = tmp_path / "file.bin"
-        f.write_bytes(b"\x00\x01\x02")
-
-        assert extract_image_dimensions(str(f), mime_type=mime) is None
-
-    def test_returns_none_for_missing_file(self, tmp_path: Path):
-        result = extract_image_dimensions(
-            str(tmp_path / "does_not_exist.png"), mime_type="image/png"
-        )
-
-        assert result is None
-
-    def test_returns_none_for_corrupt_image(self, tmp_path: Path):
-        f = tmp_path / "corrupt.png"
-        f.write_bytes(b"not actually a png file")
-
-        result = extract_image_dimensions(str(f), mime_type="image/png")
-
-        assert result is None
-
-    def test_returns_none_for_empty_file(self, tmp_path: Path):
-        f = tmp_path / "empty.png"
-        f.write_bytes(b"")
-
-        result = extract_image_dimensions(str(f), mime_type="image/png")
-
-        assert result is None

tests-unit/assets_test/services/test_ingest.py

@@ -4,12 +4,10 @@ from pathlib import Path
 from unittest.mock import patch
 
 import pytest
-from PIL import Image
 from sqlalchemy.orm import Session as SASession, Session
 
 from app.assets.database.models import Asset, AssetReference, AssetReferenceTag, Tag
 from app.assets.database.queries import get_reference_tags
-from app.assets.helpers import get_utc_now
 from app.assets.services.ingest import (
     _ingest_file_from_path,
     _register_existing_asset,
@@ -17,11 +15,6 @@ from app.assets.services.ingest import (
 )
 
 
-def _make_png(path: Path, size: tuple[int, int]) -> Path:
-    Image.new("RGB", size, color=(80, 120, 200)).save(path, format="PNG")
-    return path
-
-
 class TestIngestFileFromPath:
     def test_creates_asset_and_reference(self, mock_create_session, temp_dir: Path, session: Session):
         file_path = temp_dir / "test_file.bin"
@@ -286,203 +279,4 @@ class TestIngestExistingFileTagFK:
             ref_tags = sess.query(AssetReferenceTag).all()
             ref_tag_names = {rt.tag_name for rt in ref_tags}
             assert "output" in ref_tag_names
-
-
-class TestIngestImageDimensions:
-    """system_metadata should carry {kind, width, height} for image assets."""
-
-    def test_image_asset_emits_dimensions(
-        self, mock_create_session, temp_dir: Path, session: Session
-    ):
-        f = _make_png(temp_dir / "shot.png", (640, 480))
-
-        result = _ingest_file_from_path(
-            abs_path=str(f),
-            asset_hash="blake3:img1",
-            size_bytes=f.stat().st_size,
-            mtime_ns=1234567890000000000,
-            mime_type="image/png",
-        )
-
-        ref = session.query(AssetReference).filter_by(id=result.reference_id).first()
-        assert ref.system_metadata == {
-            "kind": "image",
-            "width": 640,
-            "height": 480,
-        }
-
-    def test_non_image_asset_leaves_system_metadata_empty(
-        self, mock_create_session, temp_dir: Path, session: Session
-    ):
-        f = temp_dir / "model.safetensors"
-        f.write_bytes(b"not an image")
-
-        result = _ingest_file_from_path(
-            abs_path=str(f),
-            asset_hash="blake3:safetensors1",
-            size_bytes=f.stat().st_size,
-            mtime_ns=1234567890000000000,
-            mime_type="application/octet-stream",
-        )
-
-        ref = session.query(AssetReference).filter_by(id=result.reference_id).first()
-        assert ref.system_metadata in (None, {})
-
-    def test_preserves_existing_system_metadata_keys(
-        self, mock_create_session, temp_dir: Path, session: Session
-    ):
-        f = _make_png(temp_dir / "annotated.png", (100, 200))
-
-        # First pass populates a sentinel system_metadata key (simulating prior
-        # enricher write).
-        result = _ingest_file_from_path(
-            abs_path=str(f),
-            asset_hash="blake3:img-merge",
-            size_bytes=f.stat().st_size,
-            mtime_ns=1234567890000000000,
-            mime_type="image/png",
-        )
-        ref = session.query(AssetReference).filter_by(id=result.reference_id).first()
-        ref.system_metadata = {**(ref.system_metadata or {}), "source_url": "https://example/x.png"}
-        session.commit()
-
-        # Second pass with the same path triggers the merge code path again.
-        _ingest_file_from_path(
-            abs_path=str(f),
-            asset_hash="blake3:img-merge",
-            size_bytes=f.stat().st_size,
-            mtime_ns=1234567890000000001,
-            mime_type="image/png",
-        )
-
-        session.refresh(ref)
-        assert ref.system_metadata["kind"] == "image"
-        assert ref.system_metadata["width"] == 100
-        assert ref.system_metadata["height"] == 200
-        assert ref.system_metadata["source_url"] == "https://example/x.png"
-
-
-class TestRegisterExistingAssetBackfill:
-    """The from-hash path back-fills dimensions from a sibling reference."""
-
-    def _add_reference(
-        self,
-        session: Session,
-        asset: Asset,
-        name: str,
-        system_metadata: dict | None = None,
-    ) -> AssetReference:
-        now = get_utc_now()
-        ref = AssetReference(
-            asset_id=asset.id,
-            name=name,
-            owner_id="",
-            created_at=now,
-            updated_at=now,
-            last_access_time=now,
-            system_metadata=system_metadata or {},
-        )
-        session.add(ref)
-        session.flush()
-        return ref
-
-    def test_backfills_dimensions_from_sibling_image_reference(
-        self, mock_create_session, session: Session
-    ):
-        asset = Asset(hash="blake3:shared", size_bytes=2048, mime_type="image/png")
-        session.add(asset)
-        session.flush()
-        self._add_reference(
-            session,
-            asset,
-            name="original.png",
-            system_metadata={"kind": "image", "width": 800, "height": 600},
-        )
-        session.commit()
-
-        result = _register_existing_asset(
-            asset_hash="blake3:shared",
-            name="from_hash.png",
-            owner_id="user-x",
-        )
-
-        ref = session.query(AssetReference).filter_by(id=result.ref.id).first()
-        assert ref.system_metadata.get("kind") == "image"
-        assert ref.system_metadata.get("width") == 800
-        assert ref.system_metadata.get("height") == 600
-
-    def test_no_backfill_when_sibling_has_no_image_metadata(
-        self, mock_create_session, session: Session
-    ):
-        asset = Asset(hash="blake3:nodims", size_bytes=2048, mime_type="image/png")
-        session.add(asset)
-        session.flush()
-        self._add_reference(
-            session,
-            asset,
-            name="original.png",
-            system_metadata={"base_model": "flux"},  # no kind=image
-        )
-        session.commit()
-
-        result = _register_existing_asset(
-            asset_hash="blake3:nodims",
-            name="from_hash.png",
-            owner_id="user-x",
-        )
-
-        ref = session.query(AssetReference).filter_by(id=result.ref.id).first()
-        meta = ref.system_metadata or {}
-        assert "kind" not in meta
-        assert "width" not in meta
-        assert "height" not in meta
-
-    def test_no_backfill_when_no_sibling_exists(
-        self, mock_create_session, session: Session
-    ):
-        asset = Asset(hash="blake3:lonely", size_bytes=1024, mime_type="image/png")
-        session.add(asset)
-        session.commit()
-
-        result = _register_existing_asset(
-            asset_hash="blake3:lonely",
-            name="solo.png",
-            owner_id="user-x",
-        )
-
-        ref = session.query(AssetReference).filter_by(id=result.ref.id).first()
-        assert ref.system_metadata in (None, {})
-
-    def test_backfill_preserves_caller_supplied_keys(
-        self, mock_create_session, session: Session
-    ):
-        asset = Asset(hash="blake3:preserve", size_bytes=2048, mime_type="image/png")
-        session.add(asset)
-        session.flush()
-        self._add_reference(
-            session,
-            asset,
-            name="original.png",
-            system_metadata={"kind": "image", "width": 1024, "height": 768},
-        )
-        session.commit()
-
-        # Simulate a from-hash path where the new reference already carries
-        # some system_metadata (e.g. a download-provenance source_url written
-        # by an earlier step). The back-fill must merge dim keys without
-        # clobbering existing keys.
-        result = _register_existing_asset(
-            asset_hash="blake3:preserve",
-            name="from_hash.png",
-            owner_id="user-x",
-        )
-        ref = session.query(AssetReference).filter_by(id=result.ref.id).first()
-        # Seed a sentinel key and re-run back-fill via a second register call
-        # to exercise the merge path with pre-existing data.
-        ref.system_metadata = {**(ref.system_metadata or {}), "source_url": "https://example/p"}
-        session.commit()
-
-        assert ref.system_metadata.get("source_url") == "https://example/p"
-        assert ref.system_metadata.get("kind") == "image"
-        assert ref.system_metadata.get("width") == 1024
-        assert ref.system_metadata.get("height") == 768
+            assert "my-job" in ref_tag_names