youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-03-21 14:28:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(model-selector): use native button elements for Base UI trigger components

Browse Source 
Replace <div> with <button type="button"> in PopoverTrigger and
TooltipTrigger render props to satisfy Base UI's nativeButton
requirement and restore proper button semantics.
This commit is contained in:
yyh
2026-03-10 16:41:16 +08:00
parent a4942139d2
commit 369e4eb7b0
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/app/components/header/account-setting/model-provider-page/model-selector/popup-item.tsx
View File

@ -114,7 +114,7 @@ const PopupItem: FC<PopupItemProps> = ({
<Popover open={dropdownOpen} onOpenChange={setDropdownOpen}>
<PopoverTrigger
render={(
<div className="flex cursor-pointer items-center rounded-md px-1.5 py-1 text-text-tertiary system-xs-medium hover:bg-components-button-ghost-bg-hover">
<button type="button" className="flex cursor-pointer items-center rounded-md px-1.5 py-1 text-text-tertiary system-xs-medium hover:bg-components-button-ghost-bg-hover">
{isUsingCredits
? (
hasCredits
@ -145,7 +145,7 @@ const PopupItem: FC<PopupItemProps> = ({
</>
)}
<span className="i-ri-arrow-down-s-line !h-[14px] !w-[14px] translate-y-px text-text-tertiary" />
</div>
</button>
)}
/>
<PopoverContent placement="bottom-end">
@ -163,8 +163,9 @@ const PopupItem: FC<PopupItemProps> = ({
<Tooltip key={modelItem.model}>
<TooltipTrigger
render={(
<div
className={cn('group relative flex h-8 items-center gap-1 rounded-lg px-3 py-1.5', modelItem.status === ModelStatusEnum.active ? 'cursor-pointer hover:bg-state-base-hover' : 'cursor-not-allowed hover:bg-state-base-hover-alt')}
<button
type="button"
className={cn('group relative flex h-8 w-full items-center gap-1 rounded-lg px-3 py-1.5 text-left', modelItem.status === ModelStatusEnum.active ? 'cursor-pointer hover:bg-state-base-hover' : 'cursor-not-allowed hover:bg-state-base-hover-alt')}
onClick={() => handleSelect(model.provider, modelItem)}
>
<div className="flex items-center gap-2">
@ -193,7 +194,7 @@ const PopupItem: FC<PopupItemProps> = ({
</div>
)
}
</div>
</button>
)}
/>
<TooltipContent