youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-28 12:53:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Require deployment names before continuing

Browse Source
This commit is contained in:
Stephen Zhou
2026-05-27 23:08:43 +08:00
parent 082b223ab1
commit 40e40cf2bb
1 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
web/features/deployments/create-guide/use-create-deployment-guide.ts
View File

@ -148,10 +148,10 @@ export function useCreateDeploymentGuide() {
: method === 'bindApp'
? effectiveSelectedApp?.name ?? ''
: ''
const displayedInstanceName = instanceName.trim() || sourceName
const defaultedReleaseName = t('createGuide.release.defaultName')
const displayedReleaseName = releaseName.trim() || defaultedReleaseName
const displayedReleaseDescription = releaseDescription.trim()
const submittedInstanceName = instanceName.trim()
const submittedReleaseName = releaseName.trim()
const submittedReleaseDescription = releaseDescription.trim()
const showTargetConfiguration = Boolean(method && step === 'target')
function selectMethod(nextMethod: GuideMethod) {
@ -207,8 +207,8 @@ export function useCreateDeploymentGuide() {
return Boolean(
method
&& (method === 'importDsl' ? hasDslContent && !isReadingDsl && !dslReadError : effectiveSelectedApp?.id)
&& displayedInstanceName.trim()
&& displayedReleaseName.trim(),
&& submittedInstanceName
&& submittedReleaseName,
)
}
if (step === 'target') {
@ -220,7 +220,9 @@ export function useCreateDeploymentGuide() {
return Boolean(
selectedEnvironment?.id
&& deploymentTargetReady
&& requiredBindingsReady,
&& requiredBindingsReady
&& submittedInstanceName
&& submittedReleaseName,
)
}
return false
@ -260,6 +262,9 @@ export function useCreateDeploymentGuide() {
return
try {
if (!submittedInstanceName || !submittedReleaseName)
throw new Error('Missing required release fields.')
const missingRequiredBinding = bindingSlots.some(slot => hasMissingRequiredRuntimeCredentialBinding(slot, bindingSelections[runtimeCredentialSlotKey(slot)]))
if (missingRequiredBinding)
throw new Error('Missing required deployment binding.')
@ -270,10 +275,10 @@ export function useCreateDeploymentGuide() {
body: {
dsl: encodedDslContent,
environmentId: selectedEnvironment.id,
appInstanceName: displayedInstanceName.trim(),
appInstanceName: submittedInstanceName,
appInstanceDescription: instanceDescription.trim() || undefined,
releaseName: displayedReleaseName.trim(),
releaseDescription: displayedReleaseDescription.trim() || undefined,
releaseName: submittedReleaseName,
releaseDescription: submittedReleaseDescription || undefined,
credentials: selectedDeploymentRuntimeCredentials(bindingSlots, bindingSelections),
idempotencyKey,
expectedDslDigest: deploymentOptions?.dslDigest,
@ -284,10 +289,10 @@ export function useCreateDeploymentGuide() {
body: {
sourceAppId: effectiveSelectedApp.id,
environmentId: selectedEnvironment.id,
appInstanceName: displayedInstanceName.trim(),
appInstanceName: submittedInstanceName,
appInstanceDescription: instanceDescription.trim() || undefined,
releaseName: displayedReleaseName.trim(),
releaseDescription: displayedReleaseDescription.trim() || undefined,
releaseName: submittedReleaseName,
releaseDescription: submittedReleaseDescription || undefined,
credentials: selectedDeploymentRuntimeCredentials(bindingSlots, bindingSelections),
idempotencyKey,
expectedDslDigest: deploymentOptions?.dslDigest,