youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-04-30 23:48:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename the placeholder_values to resolved_placeholder_values in HumanInputFormApi (vibe-kanban 4b9631d6)

Browse Source 
Update tests accordingly. Ensure relevant tests are green.
This commit is contained in:
QuantumGhost
2026-01-16 13:27:35 +08:00
parent e099a8de47
commit 68d56415d0
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/controllers/web/human_input_form.py
View File

@ -43,7 +43,7 @@ def _jsonify_form_definition(form: Form, site_payload: dict | None = None) -> Re
payload = {
"form_content": definition_payload["rendered_content"],
"inputs": definition_payload["inputs"],
"placeholder_values": _stringify_placeholder_values(definition_payload["placeholder_values"]),
"resolved_placeholder_values": _stringify_placeholder_values(definition_payload["placeholder_values"]),
"user_actions": definition_payload["user_actions"],
"expiration_time": _to_timestamp(form.expiration_time),
}

10
api/tests/unit_tests/controllers/web/test_human_input_form.py
View File

@ -14,9 +14,9 @@ from werkzeug.exceptions import Forbidden
import controllers.web.human_input_form as human_input_module
import controllers.web.site as site_module
from models.human_input import RecipientType
HumanInputFormApi = human_input_module.HumanInputFormApi
RecipientType = human_input_module.RecipientType
TenantStatus = human_input_module.TenantStatus
@ -132,13 +132,13 @@ def test_get_form_includes_site(monkeypatch: pytest.MonkeyPatch, app: Flask):
"site",
"form_content",
"inputs",
"placeholder_values",
"resolved_placeholder_values",
"user_actions",
"expiration_time",
}
assert body["form_content"] == "Rendered {{#$output.name#}}"
assert body["inputs"] == [{"type": "text", "output_variable_name": "name", "placeholder": None}]
assert body["placeholder_values"] == {"name": "Alice", "age": "30", "meta": '{"k": "v"}'}
assert body["resolved_placeholder_values"] == {"name": "Alice", "age": "30", "meta": '{"k": "v"}'}
assert body["user_actions"] == [{"id": "approve", "title": "Approve", "button_style": "default"}]
assert body["expiration_time"] == int(expiration_time.timestamp())
assert body["site"] == {
@ -245,13 +245,13 @@ def test_get_form_allows_backstage_token(monkeypatch: pytest.MonkeyPatch, app: F
"site",
"form_content",
"inputs",
"placeholder_values",
"resolved_placeholder_values",
"user_actions",
"expiration_time",
}
assert body["form_content"] == "Rendered"
assert body["inputs"] == []
assert body["placeholder_values"] == {}
assert body["resolved_placeholder_values"] == {}
assert body["user_actions"] == []
assert body["expiration_time"] == int(expiration_time.timestamp())
assert body["site"] == {