youngkingdom/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-02-22 19:15:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: restore real timers before waitFor in fake timer tests and fix remaining tests

Browse Source 
Co-authored-by: hyoban <38493346+hyoban@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-04 14:09:29 +00:00
parent d48d8488a6
commit e4aaabb079
1 changed files with 30 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
web/app/components/rag-pipeline/components/update-dsl-modal.spec.tsx
View File

@ -365,7 +365,11 @@ describe('UpdateDSLModal', () => {
// Select a file
const fileInput = screen.getByTestId('file-input')
const file = new File(['test content'], 'test.pipeline', { type: 'text/yaml' })
fireEvent.change(fileInput, { target: { files: [file] } })
await act(async () => {
fireEvent.change(fileInput, { target: { files: [file] } })
await flushFileReader()
})
// Wait for FileReader to process
await waitFor(() => {
@ -375,12 +379,15 @@ describe('UpdateDSLModal', () => {
// Click import button
const importButton = screen.getByText('common.overwriteAndImport')
fireEvent.click(importButton)
await act(async () => {
fireEvent.click(importButton)
})
// Wait for import to be called
await waitFor(() => {
expect(mockImportDSL).toHaveBeenCalled()
})
}, { timeout: 5000 })
})
it('should show success notification on completed import', async () => {
@ -715,11 +722,11 @@ describe('UpdateDSLModal', () => {
await vi.advanceTimersByTimeAsync(350)
})
vi.useRealTimers()
await waitFor(() => {
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
}, { timeout: 5000 })
vi.useRealTimers()
})
it('should show version info in error modal', async () => {
@ -847,9 +854,10 @@ describe('UpdateDSLModal', () => {
await vi.advanceTimersByTimeAsync(350)
})
await waitFor(() => {
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
}, { timeout: 5000 })
vi.useRealTimers()
// Element should be immediately available after advancing timers
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
// Click confirm button
const confirmButton = screen.getByText('newApp.Confirm')
@ -861,8 +869,6 @@ describe('UpdateDSLModal', () => {
await waitFor(() => {
expect(mockImportDSLConfirm).toHaveBeenCalledWith('import-id')
}, { timeout: 5000 })
vi.useRealTimers()
})
it('should show success notification after confirm completes', async () => {
@ -1148,9 +1154,10 @@ describe('UpdateDSLModal', () => {
await vi.advanceTimersByTimeAsync(350)
})
await waitFor(() => {
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
}, { timeout: 5000 })
vi.useRealTimers()
// Element should be immediately available after advancing timers
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
const confirmButton = screen.getByText('newApp.Confirm')
@ -1161,8 +1168,6 @@ describe('UpdateDSLModal', () => {
await waitFor(() => {
expect(mockHandleCheckPluginDependencies).toHaveBeenCalledWith('test-pipeline-id', true)
}, { timeout: 5000 })
vi.useRealTimers()
})
it('should handle undefined imported_dsl_version and current_dsl_version', async () => {
@ -1178,7 +1183,11 @@ describe('UpdateDSLModal', () => {
const fileInput = screen.getByTestId('file-input')
const file = new File(['test content'], 'test.pipeline', { type: 'text/yaml' })
fireEvent.change(fileInput, { target: { files: [file] } })
await act(async () => {
fireEvent.change(fileInput, { target: { files: [file] } })
await flushFileReader()
})
await waitFor(() => {
const importButton = screen.getByText('common.overwriteAndImport')
@ -1186,12 +1195,15 @@ describe('UpdateDSLModal', () => {
})
const importButton = screen.getByText('common.overwriteAndImport')
fireEvent.click(importButton)
await act(async () => {
fireEvent.click(importButton)
})
// Should show error modal even with undefined versions
await waitFor(() => {
expect(screen.getByText('newApp.appCreateDSLErrorTitle')).toBeInTheDocument()
}, { timeout: 1000 })
}, { timeout: 5000 })
})
it('should not call importDSLConfirm when importId is not set', async () => {