Remove unused S3FS_PTHREAD_ERRORCHECK (#2703)

.github/workflows/ci.yml

@@ -145,7 +145,7 @@ jobs:
       - name: Build
         run: |
           ./autogen.sh
-          PKG_CONFIG_PATH=/usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig ./configure CXXFLAGS='-std=c++14 -DS3FS_PTHREAD_ERRORCHECK=1'
+          PKG_CONFIG_PATH=/usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig ./configure CXXFLAGS='-std=c++14'
           make --jobs=$(sysctl -n hw.ncpu)
 
       - name: Cppcheck
@@ -219,7 +219,7 @@ jobs:
       #
       - name: Set variables
         run: |
-          COMMON_CXXFLAGS='-g -Wno-cpp -DS3FS_PTHREAD_ERRORCHECK=1'
+          COMMON_CXXFLAGS='-g -Wno-cpp'
           {
             if [ "${{ matrix.checktype }}" = "glibc_debug" ]; then
                 echo "CXXFLAGS=${COMMON_CXXFLAGS} -O0 -D_GLIBCXX_DEBUG"

.github/workflows/linux-ci-helper.sh

@@ -67,7 +67,7 @@ AWSCLI_ZIP_FILE="awscliv2.zip"
 # Parameters for configure(set environments)
 #-----------------------------------------------------------
 CXX="g++"
-CXXFLAGS="-O -DS3FS_PTHREAD_ERRORCHECK=1"
+CXXFLAGS="-O"
 LDFLAGS=""
 CONFIGURE_OPTIONS="--prefix=/usr --with-openssl"