Commit Graph

2261 Commits

Author SHA1 Message Date
08a5d35f34 Add Ubuntu 24.10 to CI (#2575) 2024-10-29 00:10:44 +09:00
561ce1e206 Update ChangeLog and configure.ac for 1.95
Fixes #2496.
v1.95
2024-10-25 10:42:53 -07:00
7cb46db945 Add missing string header (#2574)
Found via clang-tidy.
2024-10-25 16:13:57 +09:00
fe82477a6b Add missing utility header for std::move (#2572)
Found via clang-tidy.
2024-10-25 14:55:01 +09:00
b8e56a40b2 Fixed a bug in clearing the queue accumulated during USR1 processing 2024-10-25 14:47:15 +09:00
3ff93d7342 Simplify bucket_block_count initialization (#2571) 2024-10-25 08:37:48 +09:00
e43de21e43 Separate clang-tidy into its own CI task (#2567)
clang-tidy takes 4 minutes on my laptop compared to ALL_TESTS=1 which
takes 8 minutes.  Using a separate tasks avoids duplicating clang-tidy
and unnecessarily slowing CI run-time.
2024-10-24 08:25:30 +09:00
31061416bc Separate serialization and deserialization code (#2566)
This is clearer than a bool parameter.
2024-10-24 08:22:35 +09:00
a8af6cb3b4 Run clang-tidy against test files (#2568) 2024-10-23 20:46:01 +09:00
fe0a62118d Remove some unused parameters (#2565) 2024-10-22 20:34:22 +09:00
cc5271ef2b Enable clang-tidy narrowing conversions (#2564) 2024-10-22 19:55:10 +09:00
d35b5a8905 Add OpenSSL suppression for ThreadSanitizer (#2559) 2024-10-22 19:52:27 +09:00
64c96e89c5 Expand use of auto (#2563)
Found via clang-tidy.
2024-10-22 19:43:12 +09:00
9c4fcbd050 Use std::max instead of conditional (#2562)
Found via clang-tidy.
2024-10-22 19:22:39 +09:00
b34e2711a7 Fixed warnings on integer comparisons (#2558)
Follows on to 2d1409a672.
2024-10-22 18:53:37 +09:00
14f07626e0 Wrap EVP_MD_CTX in a std::unique_ptr (#2557) 2024-10-20 16:07:53 +09:00
8c5ac5c2d9 Remove more raw pointers (#2556)
Make destructor public so std::unique_ptr can call it.  Also restrict
singleton creation to satisfy cppcheck.
2024-10-20 16:06:05 +09:00
4b6e53223b Use std::shared_ptr to refer to FdEntity (#2541)
FdEntity may have multiple references due to ChangeEntityToTempPath.
This relies on the std::enable_shared_from_this helper to create a
std::shared_ptr from this.  Fixes #2532.
2024-10-20 14:56:29 +09:00
a505cebf9b Expand use of std::unique_ptr for FILE* (#2555) 2024-10-18 22:06:47 +09:00
141d74f187 Use auto for iterator variable types (#2554)
This touches a few other long type names.  Applied via clang-tidy
-fix.
2024-10-18 21:57:52 +09:00
4c5b7595b4 Add missing GUARDED_BY to fdcache_entity (#2549)
This requires a fake GetMutex for the lock checker to understand the
control flow.  Also remove unneeded locking comments that annotation
supersede.  Follows on to #2491.
2024-10-18 00:39:45 +09:00
e613ae55bb Replace curl_warnings_lock with std::atomic (#2550)
This is simpler and lighter-weight.
2024-10-18 00:36:36 +09:00
5594106351 Add miscellaneous locking annotations (#2551) 2024-10-18 00:34:57 +09:00
c5031a5a97 Simplify some method parameters (#2553)
Add const where possible and avoid unnecessary reference parameters.
2024-10-18 00:05:42 +09:00
473f9df65a FreeBSD compilation fixes
Closes #2517.
2024-10-16 13:46:12 -07:00
0c26014812 Fixed exclusive control of upload_id in PseudoFdInfo class 2024-10-16 02:46:48 +09:00
06a3822965 [Improvement #2490] Add GUARDED_BY to FdEntity and fix locking 2024-10-15 02:04:46 +09:00
2d1409a672 Fixed warnings on integer comparisons in openssl_auth.cpp 2024-10-15 02:00:20 +09:00
1d3ab76cc4 Ensure that test checks data length (#2546)
wc has an optimization that can use metadata when stdin is set to a
file.  Also fix up logging.
2024-10-14 18:31:37 +09:00
c00b5fd4bb Propoagate error state from insertV4Headers (#2547)
s3fs_sha256_hex_fd returns an empty string when calculating the hash
fails.
2024-10-14 10:28:19 +09:00
000273a8de Configure target for clang thread safety checking (#2493) 2024-10-14 10:19:03 +09:00
3ba8c2a139 Replace non-standard VLAs with std::array (#2544) 2024-10-13 12:03:56 +09:00
c0219b38d1 Return correct success value from NSS s3fs_md5 (#2543) 2024-10-13 11:58:54 +09:00
40f95272be Fix locking annotations and add one missing lock (#2542)
This allows clang's thread safety checks to pass.
2024-10-13 11:53:56 +09:00
15e2eae69a Address clang-tidy 19 warnings (#2540) 2024-10-13 10:09:47 +09:00
743c86e506 Fix issues discovered by Coverity (#2535) 2024-10-08 08:07:13 +09:00
4605cc2035 Fixed fake_diskfree option 2024-10-07 01:24:35 +09:00
a259981f16 Enable cppcoreguidelines-pro-type-const-cast (#2537)
This fixes dangerous uses of const_cast.
2024-10-06 18:40:48 +09:00
bbbb2d0908 Specify deleter function for regex_t unique_ptr (#2536) 2024-10-06 18:30:22 +09:00
e80de15cc6 Make FILE ownership clearer via unique_ptr (#2534) 2024-10-06 18:03:02 +09:00
b283ab291a Modified and bypassed test_multipart_mix on MacOS with nocopyapi 2024-09-29 13:58:46 +09:00
c24015ae17 Modified and bypassed some MacOS tests 2024-09-29 09:17:11 +09:00
df5364d758 Enable readability-implicit-bool-conversion (#2530)
This fixes one real error, one misreported EPERM, and some false
positives.  References #2529.
2024-09-28 15:28:50 +09:00
52c10cd45d Call Rename outside AutoFdEntity scope (#2528)
This avoids a use-after-free in the destructor.
2024-09-28 15:25:02 +09:00
e8f1e3473c Fixed miss-return code in S3fsCurl::RequestPerform 2024-09-28 13:25:37 +09:00
37cf324c52 Return non-zero exit code on Valgrind errors (#2527)
Previously this ignored use-after-frees and other errors.
2024-09-28 11:37:25 +09:00
5691071ac6 Log entire line when curldbg lacks a newline (#2526)
Previously -o curldbg=body would read uninitialized memory.
2024-09-28 11:35:49 +09:00
6faaff10ee Fixed hardlink test for macos 2024-09-27 00:52:07 +09:00
4796e982ab Fixed opensuse/leap:15 test 2024-09-27 00:51:51 +09:00
22869d99a5 Set errno to zero before calling sysconf (#2515)
FreeBSD returns -1 since it has no limits for _SC_GETPW_R_SIZE_MAX and
_SC_GETGR_R_SIZE_MAX but is not required to reset errno.  Also fix up
logging.  Fixes #2514.
2024-08-24 09:48:54 +09:00