feat: allow --comfy-api-base target ephemeral testenvs

Signed-off-by: bigcat88 <bigcat88@icloud.com>

comfy/comfy_api_env.py

@@ -0,0 +1,46 @@
+"""Runtime config the frontend reads from /features to follow --comfy-api-base.
+
+For a non-prod comfy.org backend (staging or an ephemeral preview env), "/features" exposes the api and
+platform base so the frontend talks to it without a rebuild; the frontend picks the Firebase project from the api base.
+Prod bases are left alone and keep their build-time defaults.
+"""
+
+from typing import Any
+from urllib.parse import urlparse
+
+from comfy.cli_args import args
+
+# Staging and the ephemeral preview envs ("testenvs") are one tier: same dev Firebase project and platform.
+_STAGING_API_HOST = "stagingapi.comfy.org"
+_TESTENV_HOST_SUFFIX = ".testenvs.comfy.org"
+_STAGING_PLATFORM_BASE_URL = "https://stagingplatform.comfy.org"
+
+
+def _is_staging_tier(host: str) -> bool:
+    return host == _STAGING_API_HOST or host.endswith(_TESTENV_HOST_SUFFIX)
+
+
+def normalize_comfy_api_base(url: str) -> str:
+    """Rewrite a testenv's friendly main host to its comfy-api '-registry' sibling."""
+    parsed = urlparse(url)
+    host = parsed.hostname or ""
+    if not host.endswith(_TESTENV_HOST_SUFFIX):
+        return url
+    label = host[: -len(_TESTENV_HOST_SUFFIX)]
+    if label.endswith("-registry"):
+        return url
+    return f"{parsed.scheme or 'https'}://{label}-registry{_TESTENV_HOST_SUFFIX}"
+
+
+def frontend_config_for_base(base_url: str) -> dict[str, Any] | None:
+    """The /features overrides for a staging-tier base, or None for prod."""
+    if not _is_staging_tier(urlparse(base_url).hostname or ""):
+        return None
+    return {
+        "comfy_api_base_url": normalize_comfy_api_base(base_url).rstrip("/"),
+        "comfy_platform_base_url": _STAGING_PLATFORM_BASE_URL,
+    }
+
+
+def get_frontend_config() -> dict[str, Any] | None:
+    return frontend_config_for_base(getattr(args, "comfy_api_base", "") or "")

comfy_api/feature_flags.py

@@ -9,6 +9,7 @@ import logging
 from typing import Any, TypedDict
 
 from comfy.cli_args import args
+from comfy.comfy_api_env import get_frontend_config
 
 
 class FeatureFlagInfo(TypedDict):
@@ -162,4 +163,11 @@ def get_server_features() -> dict[str, Any]:
     Returns:
         Dictionary of server feature flags
     """
-    return SERVER_FEATURE_FLAGS.copy()
+    features = SERVER_FEATURE_FLAGS.copy()
+    # When --comfy-api-base targets a staging-tier comfy.org backend (the staging api host or an ephemeral testenv),
+    # surface the api + platform base so the frontend can reach it without a rebuild
+    # (it derives the Firebase project from the api base). Prod / self-hosted bases keep build-time defaults.
+    overrides = get_frontend_config()
+    if overrides:
+        features.update(overrides)
+    return features

comfy_api_nodes/util/_helpers.py

@@ -11,6 +11,7 @@ from io import BytesIO
 from yarl import URL
 
 from comfy.cli_args import args
+from comfy.comfy_api_env import normalize_comfy_api_base
 from comfy.deploy_environment import get_deploy_environment
 from comfy.model_management import processing_interrupted
 from comfy_api.latest import IO
@@ -63,7 +64,7 @@ def get_comfy_api_headers(node_cls: type[IO.ComfyNode]) -> dict[str, str]:
 
 
 def default_base_url() -> str:
-    return getattr(args, "comfy_api_base", "https://api.comfy.org")
+    return normalize_comfy_api_base(getattr(args, "comfy_api_base", "https://api.comfy.org"))
 
 
 async def sleep_with_interrupt(

extra_model_paths.yaml.example

@@ -8,37 +8,21 @@
 #     # You can use is_default to mark that these folders should be listed first, and used as the default dirs for eg downloads
 #     #is_default: true
 #     checkpoints: models/checkpoints/
-#     configs: models/configs/
-#     loras: models/loras/
-#     vae: models/vae/
 #     text_encoders: |
 #          models/text_encoders/
-#          models/clip/
-#     diffusion_models: |
-#          models/unet/
-#          models/diffusion_models/
+#          models/clip/  # legacy location still supported
 #     clip_vision: models/clip_vision/
-#     style_models: models/style_models/
+#     configs: models/configs/
+#     controlnet: models/controlnet/
+#     diffusion_models: |
+#                  models/diffusion_models
+#                  models/unet
 #     embeddings: models/embeddings/
-#     diffusers: models/diffusers/
-#     vae_approx: models/vae_approx/
-#     controlnet: |
-#          models/controlnet/
-#          models/t2i_adapter/
-#     gligen: models/gligen/
+#     loras: models/loras/
 #     upscale_models: models/upscale_models/
-#     latent_upscale_models: models/latent_upscale_models/
-#     custom_nodes: custom_nodes/
-#     hypernetworks: models/hypernetworks/
-#     photomaker: models/photomaker/
-#     classifiers: models/classifiers/
-#     model_patches: models/model_patches/
+#     vae: models/vae/
 #     audio_encoders: models/audio_encoders/
-#     background_removal: models/background_removal/
-#     frame_interpolation: models/frame_interpolation/
-#     geometry_estimation: models/geometry_estimation/
-#     optical_flow: models/optical_flow/
-#     detection: models/detection/
+#     model_patches: models/model_patches/
 
 
 #config for a1111 ui
@@ -61,7 +45,8 @@
 #     controlnet: models/ControlNet
 
 
-# For the canonical list of supported keys and extensions, see folder_paths.py.
+# For a full list of supported keys (style_models, vae_approx, hypernetworks, photomaker,
+# model_patches, audio_encoders, classifiers, etc.) see folder_paths.py.
 
 #other_ui:
 #    base_path: path/to/ui

tests-unit/feature_flags_test.py

@@ -11,6 +11,10 @@ from comfy_api.feature_flags import (
     _coerce_flag_value,
     _parse_cli_feature_flags,
 )
+from comfy.comfy_api_env import (
+    frontend_config_for_base,
+    normalize_comfy_api_base,
+)
 
 
 class TestFeatureFlags:
@@ -181,3 +185,50 @@ class TestCliFeatureFlagRegistry:
             assert "type" in info, f"{key} missing 'type'"
             assert "default" in info, f"{key} missing 'default'"
             assert "description" in info, f"{key} missing 'description'"
+
+
+class TestComfyApiEnv:
+    """--comfy-api-base staging-tier detection + testenv main-host -> -registry rewrite."""
+
+    @pytest.mark.parametrize(
+        "url, expected",
+        [
+            # testenv friendly main host -> comfy-api -registry sibling (slash trimmed)
+            ("https://pr-4398.testenvs.comfy.org", "https://pr-4398-registry.testenvs.comfy.org"),
+            ("https://pr-4398.testenvs.comfy.org/", "https://pr-4398-registry.testenvs.comfy.org"),
+            ("https://pr-4398-registry.testenvs.comfy.org", "https://pr-4398-registry.testenvs.comfy.org"),
+            # staging + everything else -> unchanged (no -registry split)
+            ("https://stagingapi.comfy.org", "https://stagingapi.comfy.org"),
+            ("https://api.comfy.org", "https://api.comfy.org"),
+            ("https://pr-1.testenvs.comfy.org.evil.com", "https://pr-1.testenvs.comfy.org.evil.com"),
+            ("", ""),
+        ],
+    )
+    def test_normalize_comfy_api_base(self, url, expected):
+        assert normalize_comfy_api_base(url) == expected
+
+    def test_config_for_staging_tier_else_none(self):
+        # ephemeral testenv: friendly main host -> -registry, staging platform
+        eph = frontend_config_for_base("https://pr-1234.testenvs.comfy.org/")
+        assert eph["comfy_api_base_url"] == "https://pr-1234-registry.testenvs.comfy.org"
+        assert eph["comfy_platform_base_url"] == "https://stagingplatform.comfy.org"
+        # staging api host: emitted as-is
+        stg = frontend_config_for_base("https://stagingapi.comfy.org")
+        assert stg["comfy_api_base_url"] == "https://stagingapi.comfy.org"
+        assert stg["comfy_platform_base_url"] == "https://stagingplatform.comfy.org"
+        # prod / unknown: nothing
+        assert frontend_config_for_base("https://api.comfy.org") is None
+
+    def test_server_features_merge_only_for_staging_tier(self, monkeypatch):
+        def set_base(url):
+            monkeypatch.setattr(
+                "comfy.comfy_api_env.args",
+                type("Args", (), {"comfy_api_base": url})(),
+            )
+
+        set_base("https://stagingapi.comfy.org")
+        assert "comfy_api_base_url" in get_server_features()
+        set_base("https://pr-7.testenvs.comfy.org")
+        assert "comfy_api_base_url" in get_server_features()
+        set_base("https://api.comfy.org")
+        assert "comfy_api_base_url" not in get_server_features()